GRECLIPSE

Format/indent menus are messed up.

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1.0Release
  • Fix Version/s: 2.1.1Release
  • Component/s: User Interface
  • Labels:
    None
  • Environment:
    Eclipse RCP 3.6.1 or STS 2.5.1-release
    + current SVN checked out Groovy Eclipse (i.e. 2.1.0 release plus recent fixes)
  • Number of attachments :
    1

Description

I've only tried this in STS, but it is probably a Groovy Eclipse problem.

When editor is open on a groovy file, when we look in the "source" menu, either from context menu or main menu bar, I noticed that the "format" menu item is blank, except for the key info (I'm really only guessing this is the format menu .

Not sure why this happens or since when.

When editing a Java file this menu item looks normal.

I've also noticed that for some reason in STS, the key binding is sometimes changed to "Esc CTRL-F" instead of SHIFT CTRL-F. Also keubinding for 'indent' doesn't appear (and doesn't work) for me in STS.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kris De Volder added a comment -

I tried this in 'just Eclipse' with Groovy Eclipse and the menus are similarly messed up. This is not an STS issue.

It seems the format command can still be executed (by selecting this blank menu item) but it looks very ugly to have an empty item.

Show
Kris De Volder added a comment - I tried this in 'just Eclipse' with Groovy Eclipse and the menus are similarly messed up. This is not an STS issue. It seems the format command can still be executed (by selecting this blank menu item) but it looks very ugly to have an empty item.
Kris De Volder made changes -
Field Original Value New Value
Environment Eclipse RCP 3.6.1 or STS 2.5.1-release
+ current SVN checked out Groovy Eclipse (i.e. 2.1.0 release plus recent fixes)
Hide
Permalink
Kris De Volder added a comment -

I think the culprits are the (relatively new) classes
FormatGroovyAction
FormatAllGroovyAction
and the corresponding indent related ones.

I noticed that they were missing calls to 'setText' which do appear in the indent classes.

So the text on the menus was easy enough to fix.

I'm still a bit worried however that the in the main menu under source we find 'correct indentation' as title while the Groovy indentation actions set the text to 'Indent'. So I worry that is actually using a different action there.

Also, the keybindings for the Groovy actions are still messed up for me. CTRL-I and CTRL-SHIFT-f do not work for me in the Groovy editor. I am not sure of this, but I think this problem also appeared when those Format/Indent action classes where introduced.

Show
Kris De Volder added a comment - I think the culprits are the (relatively new) classes FormatGroovyAction FormatAllGroovyAction and the corresponding indent related ones. I noticed that they were missing calls to 'setText' which do appear in the indent classes. So the text on the menus was easy enough to fix. I'm still a bit worried however that the in the main menu under source we find 'correct indentation' as title while the Groovy indentation actions set the text to 'Indent'. So I worry that is actually using a different action there. Also, the keybindings for the Groovy actions are still messed up for me. CTRL-I and CTRL-SHIFT-f do not work for me in the Groovy editor. I am not sure of this, but I think this problem also appeared when those Format/Indent action classes where introduced.
Hide
Permalink
Kris De Volder added a comment -

Small patch fixing the 'empty text' issue for the format menu.

This only fixes the text issue, but not the keybinding problems.

Andy tried on Windows, and it seems keybindings work fine on windows. The keybinding problem may be limitted to Linux only.

Show
Kris De Volder added a comment - Small patch fixing the 'empty text' issue for the format menu. This only fixes the text issue, but not the keybinding problems. Andy tried on Windows, and it seems keybindings work fine on windows. The keybinding problem may be limitted to Linux only.
Kris De Volder made changes -
Attachment GRE_923_fix_format_menu_text.patch [ 52561 ]
Hide
Permalink
Kris De Volder added a comment -

A similar, but lesser problem exists with 'organize import' action. In the Java editor in the menu it correctly shows the keyboard shortcut as 'CTRL-SHIFT-O'. In the Groovy editor it only shows the action without kyebinding. Fortunately in this case, the keybinding does work even though it isn't being shown in the menu.

Show
Kris De Volder added a comment - A similar, but lesser problem exists with 'organize import' action. In the Java editor in the menu it correctly shows the keyboard shortcut as 'CTRL-SHIFT-O'. In the Groovy editor it only shows the action without kyebinding. Fortunately in this case, the keybinding does work even though it isn't being shown in the menu.
Kris De Volder made changes -
Patch Submitted [Yes]
Hide
Permalink
Kris De Volder added a comment -

I suggest at least applying this simple patch that fixes the menu texts, even though I haven't been able to figure out why the keybindings are messed up in Linux.

Show
Kris De Volder added a comment - I suggest at least applying this simple patch that fixes the menu texts, even though I haven't been able to figure out why the keybindings are messed up in Linux.
Hide
Permalink
Andrew Eisenberg added a comment -

Applied patch. Will commit later today.

Show
Andrew Eisenberg added a comment - Applied patch. Will commit later today.
Hide
Permalink
Andrew Eisenberg added a comment -

Fix is committed.

Show
Andrew Eisenberg added a comment - Fix is committed.
Andrew Eisenberg made changes -
Status Open [ 1 ] Resolved [ 5 ]
Assignee Kris De Volder [ kdvolder ]
Fix Version/s 2.1.1Release [ 16772 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Kris De Volder added a comment -

Reopening: Actually, the patch is only a partial fix. Only menu text is fixed, keybindings still a mess, at least on Linux.

Andrew, when you are next in the office, maybe we can have a look at this together. I don't really understand the whole Editor action stuff. This used to work before, but I think it got broken when you made it so the format/indent actions can now apply to portions of a file.

Show
Kris De Volder added a comment - Reopening: Actually, the patch is only a partial fix. Only menu text is fixed, keybindings still a mess, at least on Linux. Andrew, when you are next in the office, maybe we can have a look at this together. I don't really understand the whole Editor action stuff. This used to work before, but I think it got broken when you made it so the format/indent actions can now apply to portions of a file.
Kris De Volder made changes -
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Hide
Permalink
Kris De Volder added a comment -

Unsetting patch flag, since patch is applied.

Show
Kris De Volder added a comment - Unsetting patch flag, since patch is applied.
Kris De Volder made changes -
Patch Submitted [Yes]
Hide
Permalink
Andrew Eisenberg added a comment -

I made a change to the plugin.xml for the org.codehaus.groovy.eclipse.refactoring plugin and now keybindings are being applied properly.

It looks like a change I made a couple of weeks ago inadvertently caused keybinding conflicts between the Java formatting/indenting commands and the Groovy variants of the same. Undoing the change seems to have helped.

Show
Andrew Eisenberg added a comment - I made a change to the plugin.xml for the org.codehaus.groovy.eclipse.refactoring plugin and now keybindings are being applied properly. It looks like a change I made a couple of weeks ago inadvertently caused keybinding conflicts between the Java formatting/indenting commands and the Groovy variants of the same. Undoing the change seems to have helped.
Andrew Eisenberg made changes -
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Kris De Volder
    Reporter:
    Kris De Volder
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: