Format/indent menus are messed up.

I tried this in 'just Eclipse' with Groovy Eclipse and the menus are similarly messed up. This is not an STS issue.

It seems the format command can still be executed (by selecting this blank menu item) but it looks very ugly to have an empty item.

I think the culprits are the (relatively new) classes
FormatGroovyAction
FormatAllGroovyAction
and the corresponding indent related ones.

I noticed that they were missing calls to 'setText' which do appear in the indent classes.

So the text on the menus was easy enough to fix.

I'm still a bit worried however that the in the main menu under source we find 'correct indentation' as title while the Groovy indentation actions set the text to 'Indent'. So I worry that is actually using a different action there.

Also, the keybindings for the Groovy actions are still messed up for me. CTRL-I and CTRL-SHIFT-f do not work for me in the Groovy editor. I am not sure of this, but I think this problem also appeared when those Format/Indent action classes where introduced.

Small patch fixing the 'empty text' issue for the format menu.

This only fixes the text issue, but not the keybinding problems.

Andy tried on Windows, and it seems keybindings work fine on windows. The keybinding problem may be limitted to Linux only.

A similar, but lesser problem exists with 'organize import' action. In the Java editor in the menu it correctly shows the keyboard shortcut as 'CTRL-SHIFT-O'. In the Groovy editor it only shows the action without kyebinding. Fortunately in this case, the keybinding does work even though it isn't being shown in the menu.

I suggest at least applying this simple patch that fixes the menu texts, even though I haven't been able to figure out why the keybindings are messed up in Linux.

Applied patch. Will commit later today.

Fix is committed.

Reopening: Actually, the patch is only a partial fix. Only menu text is fixed, keybindings still a mess, at least on Linux.

Andrew, when you are next in the office, maybe we can have a look at this together. I don't really understand the whole Editor action stuff. This used to work before, but I think it got broken when you made it so the format/indent actions can now apply to portions of a file.

Unsetting patch flag, since patch is applied.

I made a change to the plugin.xml for the org.codehaus.groovy.eclipse.refactoring plugin and now keybindings are being applied properly.

It looks like a change I made a couple of weeks ago inadvertently caused keybinding conflicts between the Java formatting/indenting commands and the Groovy variants of the same. Undoing the change seems to have helped.