jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Signup
GRECLIPSE
  • GRECLIPSE
  • GRECLIPSE-854 Better support for binary groovy files
  • GRECLIPSE-866

Proper code select support in binary groovy files

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Sub-task Sub-task
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.0RC2
  • Fix Version/s: 2.8.0.Release
  • Component/s: Editor
  • Labels:
    None
  • Number of attachments :
    0

Description

Code select will not work in binary groovy files because the codeSelect will call the SelectionEngine that tries to parse the underlying source code as Java. We need to create a GroovyClassFile class and have it instantiated in the same way that GroovyCompilationUnit is instantiated (ie- delegated to the LanguageSupportFactory.

We also need to have both implement the same interface (maybe something like IGroovyTypeRoot). Then we need to reference the interface in all places, rather than the concrete classes.

With this in place, it would be easy to override ClassFile's call to SelectionEngine and to use our own mechanism instead.

However, this is a major refactoring and I am not comfortable doing this yet.

Activity

  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Andrew Eisenberg added a comment - 05/Apr/13 9:50 PM

This is now available in latest snapshot build.

Show
Andrew Eisenberg added a comment - 05/Apr/13 9:50 PM This is now available in latest snapshot build.

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Andrew Eisenberg
Vote (2)
Watch (3)

Dates

  • Created:
    25/Oct/10 3:10 PM
    Updated:
    05/Apr/13 9:50 PM
    Resolved:
    05/Apr/13 9:50 PM
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.