GRECLIPSE

Missing underlines when call to a non-static method from a static context

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.5.1Release
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

I have this:

class Foo {
static main(args)

{ printit() }

def printit()

{ print 'Message' }

}

printit() in main is not underlined. This code won't work as printit is not declared static. Should printit() have been underlined...

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Eisenberg added a comment -

The problem here is that type inferencing and underlining only check to see if a particular keyword is resolvable. It does not go the extra step to see if something is legal. However, this is a reasonable request and we should do something here.

Show
Andrew Eisenberg added a comment - The problem here is that type inferencing and underlining only check to see if a particular keyword is resolvable. It does not go the extra step to see if something is legal. However, this is a reasonable request and we should do something here.
Hide
Permalink
Andrew Eisenberg added a comment -

Based on GRECLIPSE-1079, I thought that I could fix both this issue and that one using much of the same code. I am able to ensure underlines exists when there is an explicit class reference, but it is much harder in the situation you have above.

For example:

Foo.printit()

is easy since we know that the target of the method call is the Foo class.

However, whenever there is an implicit class reference in a static context, the call is actually routed through this, which at runtime, I believe resolves to the class. At this point, it is hard to determine that the situation above is really a static context.

For now, I will partially fix this bug and I'll think if I can find a more complete solution.

Show
Andrew Eisenberg added a comment - Based on GRECLIPSE-1079 , I thought that I could fix both this issue and that one using much of the same code. I am able to ensure underlines exists when there is an explicit class reference, but it is much harder in the situation you have above. For example: Foo.printit() is easy since we know that the target of the method call is the Foo class. However, whenever there is an implicit class reference in a static context, the call is actually routed through this , which at runtime, I believe resolves to the class. At this point, it is hard to determine that the situation above is really a static context. For now, I will partially fix this bug and I'll think if I can find a more complete solution.
Hide
Permalink
Andrew Eisenberg added a comment -

OK. With a little more intelligence, I have a complete solution. I still need to make some tests for this.

Show
Andrew Eisenberg added a comment - OK. With a little more intelligence, I have a complete solution. I still need to make some tests for this.
Hide
Permalink
Andrew Eisenberg added a comment -

Fixed with regression tests.

Show
Andrew Eisenberg added a comment - Fixed with regression tests.

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Andy Clement
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: