GRECLIPSE

Better support for binary groovy files

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 2.1.0RC2
  • Fix Version/s: None
  • Component/s: Editor
  • Labels:
    None
  • Number of attachments :
    0

Description

Currently, when viewing binary files that come from groovy sources in a class file editor, there are several problems and they all come from the fact that the generated byte code does not cleanly match with the original source code. The line number mappings do not appear to be the major cause of the issue, but rather the fact that properties and methods are named differently in the binary than in the source.

For example, setting breakpoints is problematic, navigation using the outline view often does not work, Java search will often miss some references, and the outline view will show many generated methods that do not appear in the source.

Activity

Ascending order - Click to sort in descending order
Andrew Eisenberg made changes -
Field Original Value New Value
Original Estimate 0 minutes [ 0 ]
Remaining Estimate 0 minutes [ 0 ]
Assignee Andrew Eisenberg [ werdna ]
Fix Version/s 2.1.1Release [ 16772 ]
Hide
Permalink
Andrew Eisenberg added a comment -

Consider this for the 2.1.1 release.

Show
Andrew Eisenberg added a comment - Consider this for the 2.1.1 release.
Hide
Permalink
Andrew Eisenberg added a comment -

There are 3 pieces that I can tell that need working on:

  1. Removal of all of the binary members that are not in the source file (eg- closure classes, property getters and setters, and generated fields)
  2. Code select
  3. Search

I have the first part working in my workspace now. It requires some changes to SourceMapper. The solution is after calculating source locations for a class file, to filter out all type members with invalid source locations. This appears to work, but I want to create some tests before committing.

The second two are probably not particularly difficult, but will be a very large refactoring. I will create sub-tasks for each of these.

Show
Andrew Eisenberg added a comment - There are 3 pieces that I can tell that need working on: Removal of all of the binary members that are not in the source file (eg- closure classes, property getters and setters, and generated fields) Code select Search I have the first part working in my workspace now. It requires some changes to SourceMapper. The solution is after calculating source locations for a class file, to filter out all type members with invalid source locations. This appears to work, but I want to create some tests before committing. The second two are probably not particularly difficult, but will be a very large refactoring. I will create sub-tasks for each of these.
Andrew Eisenberg made changes -
Fix Version/s 2.1.2 [ 16995 ]
Fix Version/s 2.1.1Release [ 16772 ]
Andrew Eisenberg made changes -
Assignee Andrew Eisenberg [ werdna ]
Andrew Eisenberg made changes -
Fix Version/s 2.2.0Release [ 17186 ]
Fix Version/s 2.1.2Release [ 16995 ]
Andrew Eisenberg made changes -
Fix Version/s 2.5.2.Release [ 17434 ]
Fix Version/s 2.5.1Release [ 17186 ]
Andrew Eisenberg made changes -
Fix Version/s 2.5.2.Release [ 17434 ]
Priority Major [ 3 ] Minor [ 4 ]
Hide
Permalink
Dado Comm added a comment -

Hi,

Is there any progress on these issues or are there any plans to tackle them? They are pretty old now and still important to resolve, I would say. Since I do a lot of debugging through grails internals, for me this is the main obstacle to use sts for grails development (I'm forced to use IDEA). Please, fix them if possible. Tnx

Show
Dado Comm added a comment - Hi, Is there any progress on these issues or are there any plans to tackle them? They are pretty old now and still important to resolve, I would say. Since I do a lot of debugging through grails internals, for me this is the main obstacle to use sts for grails development (I'm forced to use IDEA). Please, fix them if possible. Tnx
Hide
Permalink
Andrew Eisenberg added a comment -

I haven't gotten much further in this area yet. It's still on the TODO list, but keeps getting pushed down when other priorities come up. That being said, I should have some time to look at this post 2.8.0 release.

Show
Andrew Eisenberg added a comment - I haven't gotten much further in this area yet. It's still on the TODO list, but keeps getting pushed down when other priorities come up. That being said, I should have some time to look at this post 2.8.0 release.

People

  • Assignee:
    Unassigned
    Reporter:
    Andrew Eisenberg
Vote (4)
Watch (3)

Dates

  • Created:
    Updated: