GRECLIPSE

"New Groovy Class" wizard creates import statement that ends in semicolon

Details

  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

Create a new class and specify a superclass from a different package. The import statement created for the superclass ends in an (unnecessary) semicolon.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Curtis added a comment -

Added code in NewCLassWizardPage.java to handle semicolon's at the end of import statements for Groovy Classes generated with superclass's from a different package.

Show
Curtis added a comment - Added code in NewCLassWizardPage.java to handle semicolon's at the end of import statements for Groovy Classes generated with superclass's from a different package.
Hide
Permalink
Andrew Eisenberg added a comment -

Thanks for the patch, Curtis. I made a few changes to it so that rather than calling unit.applyTextEdit(..) three times, all of the TextEdit}}s are combined into a single {{MultiTextEdit and applied at the end of the method. I am attaching the final patch so you can see the changes.

Show
Andrew Eisenberg added a comment - Thanks for the patch, Curtis. I made a few changes to it so that rather than calling unit.applyTextEdit(..) three times, all of the TextEdit}}s are combined into a single {{MultiTextEdit and applied at the end of the method. I am attaching the final patch so you can see the changes.
Hide
Permalink
Andrew Eisenberg added a comment -

Fixed and committed.

Show
Andrew Eisenberg added a comment - Fixed and committed.

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Peter Niederwieser
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: