[formatter] Wrong identation on moving code with CTRL + PAGE_DOWN

This is probably related to our auto-indenting strategy. I am assigning to Kris to investigate.

Looking into it. My first guess is that we haven't intercepted the "CTRL-PG[UP|DN]" action and it is using the one provided by the Java editor. This is of course not working well for groovy code (especially when ";" are missing).

Hmm... Two points:

1) First off, CTRL-PG[UP|DN] doesn't work at all for me. However, ALT+[UP|DN]-ARROW seems to do what is described. (Maybe this is a "Linux versus windows" thing?

2) When I try this with ALT+[UP-ARROW|DN-ARROW] it works fine for me. Perhaps the "bug" is already fixed because of the fixes that I did a while ago re "smart copy and paste". Either that, or I don't have enough info to reproduce.

Rene, could you try again with a version of groovy eclipse installed from the snapshot update site?
http://dist.codehaus.org/groovy/distributions/greclipse/snapshot/e3.6/

If you still have a problem with this, please post a "complete" example. I.e. the code that we are "moving up & down" must be inside of some larger file, and the contents of the file itself may play a role in triggering the bug. So please include the whole file of the example.

If it seems like this is fixed in the latest build, then please confirm so we can close this bug as fixed.

Kris

1) You are correct, it is ALT instead of CTRL.

2) The example I posted is the necessary minimum to reproduce the problem. The version I have installed is 2.1.0.xx-20101007-1100-e36-RC2, which is also the latest available snapshot.

Any ideas how to proceed?

OK, since you are on rather recent version, and since work I did on this is quote a while ago, I'm assuming the problem still exists. However, I'm not able to reproduce yet, so need more info.

You say "The example I posted is the necessary minimum to reproduce the problem". But it is actually less than the minimum, because if I just paste your example code into an empty file then there's no point moving the code around. So I gather some other code has to be placed before/after that code for the example to be meaningful.

I tried to just place some empty lines around it, also I tried a simple class with a method and place the statements inside the method.

In both cases moving the code around seems to work just fine, even when it is being moved from inside the method to outside the method and vice versa.

So, if you still have some example that breaks the ALT-[UP|DN]ARROW function, can you post a more complete version of it (i.e. including the surrounding lines of code in the file)?

Also to be sure we are talking about the same function: ALT-PGDN doesn't do anything for me only ALT-DN*ARROW*. But I gather this is what you meant anyway.

Thanks

Kris

I suspect this problem isn't fixed, but unfortunately without more info, I can't reproduce. So I'll close this issue for now with "cannot reproduce". Please feel free to reopen it if you have some more info on how I might reproduce it.

Maybe the formatter settings have been the cause why you could not reproduce it.

Can you try to reproduce it with the below settings:

Preferences -> Java -> Code Style -> Formatter -> Edit... -> Identation:

Tab policy: Spaces only
Indentation size: 4
Tab size: 4

Tab/space settings don't seem to break the behavior either.

If this bug is still bugging you (pardon the pun . I'll need a more complete example to reproduce. Probably what should do it if you include an example where you show both the lines of code that are being moved and the surrounding lines.

The behavior of moving lines around inside the file is very dependent on the file they are in, not just the lines themselves.

Kris

I attached a small demo project containing a single Groovy class. Via ALT+UP and ALT+DOWN I am moving the lines. See the attached screencast for details how the identation goes wrong.

Yes! With this example I am getting the funny behavior!

I'm on version 2.5.1 and I am having indentation problems. Here is an example:

class Bug842 {
  void f1() {
    def x = [1] // move this line down with Alt+Down
    println x[0]
  }

  void f2() {
    def x = [1] // move this line down with Alt+Down
    println x[0];
  }

  void f3() {
    def x = [1] // move this line down with Alt+Down
    println x.size()
  }
}

If I move down the first line in "f1", it is not indented correctly (for my settings of two-space indents); it is indented ten spaces to the right of the "p" in the line that is now above it (fourteen spaces in total). If I move down the first line in "f2" or "f3" it is indented correctly. The difference is that the second line in "f2" ends with a semicolon and the second line in "f3" does not end with a "]". A line ending with a "]" seems to be the cause of the problem.

See GRECLIPSE-1312.