GRECLIPSE

[formatter] Remove whitespace at end of line works sporadically

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1.0RC1
  • Fix Version/s: 2.1.1Release
  • Component/s: Formatting
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

It looks like removing whitespace at the end of a line works sometimes when formatting. From what I can see, it works after a semi-colon as well as after a ->. It may work in other situations too, but these are the ones I have tried. After lines that do not have a ';', whitespace is not removed on format.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rene Scheibe added a comment -

I put together some trailing whitespace examples.
Included is also the expected output after removing the whitespaces.

Show
Rene Scheibe added a comment - I put together some trailing whitespace examples. Included is also the expected output after removing the whitespaces.
Hide
Permalink
Kris De Volder added a comment -

Rene,

Thanks for those examples. I'm putting them to good use to create a test case.

Kris

Show
Kris De Volder added a comment - Rene, Thanks for those examples. I'm putting them to good use to create a test case. Kris
Hide
Permalink
Kris De Volder added a comment -

Attaching a patch for this issue and related issue GRE_524.

Aplying this patch should make indent and format command remove whitespace at the end of line as well as handle empty lines specially in accordance with the formatter preference to "indent empty lines" as specified in the Java formatter preferences.

Show
Kris De Volder added a comment - Attaching a patch for this issue and related issue GRE_524. Aplying this patch should make indent and format command remove whitespace at the end of line as well as handle empty lines specially in accordance with the formatter preference to "indent empty lines" as specified in the Java formatter preferences.
Hide
Permalink
Kris De Volder added a comment -

The patch attached to this issue is obsolete, it is combined with the one in GRE_856.

Show
Kris De Volder added a comment - The patch attached to this issue is obsolete, it is combined with the one in GRE_856.
Hide
Permalink
Andrew Eisenberg added a comment -

Patch has been applied and this issue is fixed.

Show
Andrew Eisenberg added a comment - Patch has been applied and this issue is fixed.
Hide
Permalink
Rene Scheibe added a comment -

Is it possible to include this into save actions (like for Java)?

Show
Rene Scheibe added a comment - Is it possible to include this into save actions (like for Java)?

People

  • Assignee:
    Kris De Volder
    Reporter:
    Andrew Eisenberg
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: