GRECLIPSE

Auto-complete does not work in Groovy GString (unless both braces exist)

Details

  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

From https://issuetracker.springsource.com/browse/STS-1107

Imagine I have this method in a Groovy class:

void echo(msg) {
    println "Echoing: ${m"
}

I have started a Groovy expression in the print statement and now I want to autocomplete msg. But STS won't autocomplete the variable unless I put the closing brace in first.

I guess the most appropriate fix is to automatically add the closing brace when the user types '${' inside a double-quote string.

I've marked as major because I think it impacts usability significantly.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Eisenberg added a comment -

This comes about because the groovy parser does not recognize a snippet as a GString unless both braces exist. It looks like the parser does not break in this situation, but merely assumes that the contents inside the "" is merely a string.

Show
Andrew Eisenberg added a comment - This comes about because the groovy parser does not recognize a snippet as a GString unless both braces exist. It looks like the parser does not break in this situation, but merely assumes that the contents inside the "" is merely a string.
Hide
Permalink
Kris De Volder added a comment -

I can have a look at this. If we go with the "auto close brace" suggestion, that would be handled in the autoindentor code which also insert auto close braces when inside Java code. Need to extend this functionality in side gstrings (and """ strings as well I guess).

Show
Kris De Volder added a comment - I can have a look at this. If we go with the "auto close brace" suggestion, that would be handled in the autoindentor code which also insert auto close braces when inside Java code. Need to extend this functionality in side gstrings (and """ strings as well I guess).
Hide
Permalink
Kris De Volder added a comment -

This patch adds auto insertion of "}" braces after "${" while editing Strings.

A little of extra logic was also added to not insert the extra closing brace if it seems there's one already there.

Show
Kris De Volder added a comment - This patch adds auto insertion of "}" braces after "${" while editing Strings. A little of extra logic was also added to not insert the extra closing brace if it seems there's one already there.
Hide
Permalink
Andrew Eisenberg added a comment -

Patch is committed.

Show
Andrew Eisenberg added a comment - Patch is committed.

People

  • Assignee:
    Kris De Volder
    Reporter:
    Andrew Eisenberg
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: