GRECLIPSE

Defining enum(s) alongside class in groovy file produces compile errors intermittently

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.0Release
  • Fix Version/s: 2.1.1Release
  • Component/s: Compiler Integration
  • Labels:
    None
  • Environment:
    Eclipse Galileo, jdk 1.6_16
  • Number of attachments :
    0

Description

The following class/enum mixture in a groovy file causes Eclipse to put an error marker at the start of the file. This only happens intermittently, but the only consistent solution to the problem is for me to wipe out the projects resources plugin data and restart. It seems to happen mostly when Eclipse starts up with the groovy file editor the active editor, but I can't confirm that's the primary or even a consistent cause.

Foo.groovy
enum TEST_ENUM {
    TEST1,
    TEST2
}

public class Foo {
    def bar
}

Multiple markers at this line

  • Groovy:Can't have an abstract method in a non-abstract class. The class 'TEST_ENUM' must be declared abstract or the method 'int compareTo(java.lang.String)'
    must be implemented.
  • Groovy:Can't have an abstract method in a non-abstract class. The class 'TEST_ENUM' must be declared abstract or the method 'int compareTo(java.util.Calendar)'
    must be implemented.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andy Clement added a comment -

trying to recreate this, without much success. Tried restarting eclipse with just the editor containing that file open. I am a bit confused by the message mentioning 'Calendar' as there is nothing in that source which references calendar. Sometimes errors can get reported against the wrong files - if you are still having this issue is there some other type in the same project that is dealing with Calendar and Comparable?

Show
Andy Clement added a comment - trying to recreate this, without much success. Tried restarting eclipse with just the editor containing that file open. I am a bit confused by the message mentioning 'Calendar' as there is nothing in that source which references calendar. Sometimes errors can get reported against the wrong files - if you are still having this issue is there some other type in the same project that is dealing with Calendar and Comparable?
Hide
Permalink
Evan Slatis added a comment -

Thanks for taking a look at this, Andy. I apologize about the Calendar reference in my posting. I copied that error text from a much larger file which was using a Calendar; thus, please ignore the Calendar reference.

I did verify that the code above was able to produce the first error message before I submitted the bug. As I mentioned, it is somewhat of a Heisenberg bug, so you won't get it all the time.

As I remember, I built this test class within a larger project that also contained Java files, so joint compilation (despite not having any references to anything else) might be a problem? Sorry, but I haven't had the pleasure of working in Groovy for a few weeks now, so I haven't been bothered by this for awhile. Again, thanks for looking into it.

Show
Evan Slatis added a comment - Thanks for taking a look at this, Andy. I apologize about the Calendar reference in my posting. I copied that error text from a much larger file which was using a Calendar; thus, please ignore the Calendar reference. I did verify that the code above was able to produce the first error message before I submitted the bug. As I mentioned, it is somewhat of a Heisenberg bug, so you won't get it all the time. As I remember, I built this test class within a larger project that also contained Java files, so joint compilation (despite not having any references to anything else) might be a problem? Sorry, but I haven't had the pleasure of working in Groovy for a few weeks now, so I haven't been bothered by this for awhile. Again, thanks for looking into it.
Hide
Permalink
Jonathan Harlap added a comment -

This bug plagues me too. The environment is STS 2.3.3M2 for x64 on Ubuntu Lucid using OpenJDK 1.6.0_18 64bit and Groovy Eclipse 2.0.2.xx-20100726-1100-e36

Steps I used to reproduce the bug:

  1. Create a new Groovy project, named enum_bug, accepting all the default settings for the new project.
  2. Create a new Groovy class in enum_bug with the name EnumBug in the default package with the following code:
EnumBug.groovy
class EnumBug {
	enum MyEnum { ANNOYING, BUG }
}

This results in the following two errors, and the word "MyEnum" underlined in red.

Description Resource Path Location Type
Groovy:Can't have an abstract method in a non-abstract class. The class 'EnumBug$MyEnum' must be declared abstract or the method 'int compareTo(java.net.URI)' must be implemented. EnumBug.groovy /enum_bug/src line 2 Java Problem
Groovy:Can't have an abstract method in a non-abstract class. The class 'EnumBug$MyEnum' must be declared abstract or the method 'int compareTo(java.nio.charset.Charset)' must be implemented. EnumBug.groovy /enum_bug/src line 2 Java Problem

Now that I look at this more closely, you can see it's complaining about URI and Charset, which are not used in this new project at all - they're used in another project which is having the same error. When I explicitly clean all projects (Project->Clean...) and let them be automatically rebuilt, the errors go away. I don't know exactly what I can do that will cause these errors to reappear - when it happens, I'll come back and comment further.

Show
Jonathan Harlap added a comment - This bug plagues me too. The environment is STS 2.3.3M2 for x64 on Ubuntu Lucid using OpenJDK 1.6.0_18 64bit and Groovy Eclipse 2.0.2.xx-20100726-1100-e36 Steps I used to reproduce the bug: Create a new Groovy project, named enum_bug, accepting all the default settings for the new project. Create a new Groovy class in enum_bug with the name EnumBug in the default package with the following code: EnumBug.groovy class EnumBug { enum MyEnum { ANNOYING, BUG } } This results in the following two errors, and the word "MyEnum" underlined in red. Description Resource Path Location Type Groovy:Can't have an abstract method in a non-abstract class. The class 'EnumBug$MyEnum' must be declared abstract or the method 'int compareTo(java.net.URI)' must be implemented. EnumBug.groovy /enum_bug/src line 2 Java Problem Groovy:Can't have an abstract method in a non-abstract class. The class 'EnumBug$MyEnum' must be declared abstract or the method 'int compareTo(java.nio.charset.Charset)' must be implemented. EnumBug.groovy /enum_bug/src line 2 Java Problem Now that I look at this more closely, you can see it's complaining about URI and Charset, which are not used in this new project at all - they're used in another project which is having the same error. When I explicitly clean all projects (Project->Clean...) and let them be automatically rebuilt, the errors go away. I don't know exactly what I can do that will cause these errors to reappear - when it happens, I'll come back and comment further.
Hide
Permalink
Jonathan Harlap added a comment -

The errors reappeared when I started flipping between Grails and Java perspectives, and then it was harder to get rid of them, and then they didn't reappear for a while - very weird behaviour.

As an experiment, I've created a new workspace (the one I had been using was originally created with Eclipse 3.5, then used with 3.6 and then with STS 2.3.3M2 based on 3.6) and imported the projects into it, and at least for the moment the errors have not recurred. So perhaps the problem is something in the cruft that accumulates in the workspace metadata...

Show
Jonathan Harlap added a comment - The errors reappeared when I started flipping between Grails and Java perspectives, and then it was harder to get rid of them, and then they didn't reappear for a while - very weird behaviour. As an experiment, I've created a new workspace (the one I had been using was originally created with Eclipse 3.5, then used with 3.6 and then with STS 2.3.3M2 based on 3.6) and imported the projects into it, and at least for the moment the errors have not recurred. So perhaps the problem is something in the cruft that accumulates in the workspace metadata...
Hide
Permalink
Andy Clement added a comment -

I tried the steps you mentioned (creating the enum_bug project), but that just behaved for me. If you see it again, let me know, I would like to get to the bottom of this mysterious thing.

Show
Andy Clement added a comment - I tried the steps you mentioned (creating the enum_bug project), but that just behaved for me. If you see it again, let me know, I would like to get to the bottom of this mysterious thing.
Hide
Permalink
Nicholas Smith added a comment - - edited

Just had this crop up today; edited an existing domain class that has previously been fine (for a good while). Now the enum in the same file is complaining with the same error as above.

Different to the above users though, I have an enum in a file on it's own and is now complaining of the same.

In my case project->clean does not fix the errors.

Version: : 2.0.2.20100706-2000-e35
STS: 2.3.2
OS: Vista
Project type: Grails

Sorry I can't add any more on how to reproduce.

============================================
Edit:

Not sure if you can work off this, but 2.3.2 Project->Clean does not resolve the errors; however a clean in 2.3.3M2 does.

Show
Nicholas Smith added a comment - - edited Just had this crop up today; edited an existing domain class that has previously been fine (for a good while). Now the enum in the same file is complaining with the same error as above. Different to the above users though, I have an enum in a file on it's own and is now complaining of the same. In my case project->clean does not fix the errors. Version: : 2.0.2.20100706-2000-e35 STS: 2.3.2 OS: Vista Project type: Grails Sorry I can't add any more on how to reproduce. ============================================ Edit: Not sure if you can work off this, but 2.3.2 Project->Clean does not resolve the errors; however a clean in 2.3.3M2 does.
Hide
Permalink
Peter Niederwieser added a comment -

We've been hit by this bug too. At one point, one of our devs just couldn't make it go away anymore, so we moved all enums in our project to separate files. This is one of these bugs which comes and goes at seemingly arbitrary times, and I haven't found a way to reproduce it. Nowadays, most of our Groovy Eclipse-related problems are in this category. (For example, we still have problems with syntax highlighting and other editor features coming and going without apparent reason.)

Show
Peter Niederwieser added a comment - We've been hit by this bug too. At one point, one of our devs just couldn't make it go away anymore, so we moved all enums in our project to separate files. This is one of these bugs which comes and goes at seemingly arbitrary times, and I haven't found a way to reproduce it. Nowadays, most of our Groovy Eclipse-related problems are in this category. (For example, we still have problems with syntax highlighting and other editor features coming and going without apparent reason.)
Hide
Permalink
Andy Clement added a comment -

Is anyone seeing this who can share a project with me that shows the failure? It might require more than one project in the workspace and is due to an interplay between state preserved for each.

Show
Andy Clement added a comment - Is anyone seeing this who can share a project with me that shows the failure? It might require more than one project in the workspace and is due to an interplay between state preserved for each.
Hide
Permalink
Andrew Eisenberg added a comment -

Will not get to for the 2.1.0 release.

Show
Andrew Eisenberg added a comment - Will not get to for the 2.1.0 release.
Hide
Permalink
Brian Daily added a comment -

I've been experiencing this problem also (Helios & Groovy-Eclipse 2.1). I was able to create a new workspace, create a new Groovy project and copy the source file over and the errors disappeared.

Show
Brian Daily added a comment - I've been experiencing this problem also (Helios & Groovy-Eclipse 2.1). I was able to create a new workspace, create a new Groovy project and copy the source file over and the errors disappeared.
Hide
Permalink
Andy Clement added a comment -

Hi Brian - don't suppose you are able to share the problematic workspace with me?

Show
Andy Clement added a comment - Hi Brian - don't suppose you are able to share the problematic workspace with me?
Hide
Permalink
Brian Daily added a comment -

Sure, I can share it. It's about 150MB. What's the best way to get it to you.

Show
Brian Daily added a comment - Sure, I can share it. It's about 150MB. What's the best way to get it to you.
Hide
Permalink
Andrew Eisenberg added a comment -

Do you have a dropbox account, you could drop it in there and send me a link? (https://www.dropbox.com/) - that is what I've typically done a few times for large files.

We could even try email.... andrew.clementATgmail.com

Andy

Show
Andrew Eisenberg added a comment - Do you have a dropbox account, you could drop it in there and send me a link? ( https://www.dropbox.com/ ) - that is what I've typically done a few times for large files. We could even try email.... andrew.clementATgmail.com Andy
Hide
Permalink
Brian Daily added a comment -

I'm not sure if this is good news or bad news but the new workspace is exhibiting the same issue now. And there is only one project in the workspace and one source file in that project. I'm zipping up the workspace folder now. I will share it on Dropbox with you (Andy C).

Show
Brian Daily added a comment - I'm not sure if this is good news or bad news but the new workspace is exhibiting the same issue now. And there is only one project in the workspace and one source file in that project. I'm zipping up the workspace folder now. I will share it on Dropbox with you (Andy C).
Hide
Permalink
Andy Clement added a comment -

Hi Brian, I have the test project (thanks!). Do you do anything to make the problem occur? I just fired up an STS against it (using the latest groovy eclipse). I had to add the sql jar but then it just builds fine. How do you observe the problem?

Show
Andy Clement added a comment - Hi Brian, I have the test project (thanks!). Do you do anything to make the problem occur? I just fired up an STS against it (using the latest groovy eclipse). I had to add the sql jar but then it just builds fine. How do you observe the problem?
Hide
Permalink
Brian Daily added a comment -

When I first created the new workspace and project and copied the source file in, the error did not occur. I have the project set to build automatically and sometime while I was editing it (maybe when I saved) the error indicators appeared. Could it be something "global" rather than project specific. If you'd like any of the settings files from my Eclipse installation folder let me know.

Show
Brian Daily added a comment - When I first created the new workspace and project and copied the source file in, the error did not occur. I have the project set to build automatically and sometime while I was editing it (maybe when I saved) the error indicators appeared. Could it be something "global" rather than project specific. If you'd like any of the settings files from my Eclipse installation folder let me know.
Hide
Permalink
Andy Clement added a comment -

recreated it! Thanks Brian. Proving extremely tricky to debug though as if I attempt anything (like running in debug mode) the problem goes away - but this is a big step forward.

Show
Andy Clement added a comment - recreated it! Thanks Brian. Proving extremely tricky to debug though as if I attempt anything (like running in debug mode) the problem goes away - but this is a big step forward.
Hide
Permalink
Andy Clement added a comment -

I've just put in a change that may address this issue. I'm still having problems reliably recreating it and debugging it, but I think I've seen enough. When multiple parameterizations of a type exist (e.g. Comparable<String> Comparable<Integer> etc etc) the Comparable root generic type was collecting methods it should not have done (so instead of just compareTo(Object) it was collecting compareTo(String) etc). I'm slightly concerned because this problem would affect all generic types, not just compareTo so I don't understand why I'm not flooded with issues related to this, and it only really shows up when using an enum (and then intermittently). Anyway, please upgrade to the latest dev build at the 3.6 snapshot site and do let me know if things get better or worse:

http://dist.codehaus.org/groovy/distributions/greclipse/snapshot/e3.6/

Show
Andy Clement added a comment - I've just put in a change that may address this issue. I'm still having problems reliably recreating it and debugging it, but I think I've seen enough. When multiple parameterizations of a type exist (e.g. Comparable<String> Comparable<Integer> etc etc) the Comparable root generic type was collecting methods it should not have done (so instead of just compareTo(Object) it was collecting compareTo(String) etc). I'm slightly concerned because this problem would affect all generic types, not just compareTo so I don't understand why I'm not flooded with issues related to this, and it only really shows up when using an enum (and then intermittently). Anyway, please upgrade to the latest dev build at the 3.6 snapshot site and do let me know if things get better or worse: http://dist.codehaus.org/groovy/distributions/greclipse/snapshot/e3.6/
Hide
Permalink
Andy Clement added a comment -

no negative feedback since putting the change in. believed fixed.

Show
Andy Clement added a comment - no negative feedback since putting the change in. believed fixed.
Hide
Permalink
David Tonhofer added a comment -

In Eclipse Platform Version: 3.6.1 (M20100909-0800), with jdk1.6.0_26__32 and

org.codehaus.groovy.eclipse.feature (2.5.2.xx-20110921-1500-e36) "Groovy-Eclipse plugin"
org.codehaus.groovy.jdt.patch (2.5.2.xx-20110921-1500-e36) "Groovy-Eclipse plugin"
org.codehaus.groovy17.feature (2.5.2.xx-20110921-1500-e36) "Groovy-Eclipse plugin"
org.codehaus.groovy18.feature (2.5.2.xx-20110921-1500-e36) "Groovy-Eclipse plugin"

The following code from the "logback" package yields a compile error on NestingType:

ch/qos/logback/classic/gaffer/NestedType.groovy (NB not NestingType)

package ch.qos.logback.classic.gaffer

enum NestingType {
  NA, SINGLE, AS_COLLECTION; 
}

Groovy:Can't have an abstract method in a non-abstract class. The class 'ch.qos.logback.classic.gaffer.NestingType' must be declared abstract or the method 'int compareTo(java.lang.Object)' must be implemented.

Show
David Tonhofer added a comment - In Eclipse Platform Version: 3.6.1 (M20100909-0800), with jdk1.6.0_26__32 and org.codehaus.groovy.eclipse.feature (2.5.2.xx-20110921-1500-e36) "Groovy-Eclipse plugin" org.codehaus.groovy.jdt.patch (2.5.2.xx-20110921-1500-e36) "Groovy-Eclipse plugin" org.codehaus.groovy17.feature (2.5.2.xx-20110921-1500-e36) "Groovy-Eclipse plugin" org.codehaus.groovy18.feature (2.5.2.xx-20110921-1500-e36) "Groovy-Eclipse plugin" The following code from the "logback" package yields a compile error on NestingType: ch/qos/logback/classic/gaffer/NestedType.groovy (NB not NestingType) package ch.qos.logback.classic.gaffer enum NestingType { NA, SINGLE, AS_COLLECTION; } Groovy:Can't have an abstract method in a non-abstract class. The class 'ch.qos.logback.classic.gaffer.NestingType' must be declared abstract or the method 'int compareTo(java.lang.Object)' must be implemented.

People

  • Assignee:
    Andy Clement
    Reporter:
    Evan Slatis
Vote (3)
Watch (6)

Dates

  • Created:
    Updated:
    Resolved: