Details
-
Type:
New Feature
-
Status:
Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0.0m2
-
Fix Version/s: 2.0.0RC1, 2.0.1Release
-
Component/s: Refactoring
-
Labels:None
-
Environment:Linux, gtk, x86
-
Patch Submitted:Yes
-
Number of attachments :
Description
Currently groovy plugin doesnt support rename participant callback, i.e., if somebody wants to listen to changes in groovy source code and want to participate in groovy rename refactoring then groovy plugin doesnt support rename participation.
This patch looks great. There are a few things however.
1. Could you please add ASL licenses to the top of each created file? Feel free to add your own name to the top. For example, this:
/*
*
*
*
*/
2. Does you patch include any copied code? I am specifically looking at GroovyParticipantExtensionPoint. If this is copied from EPL or ASL code, please include the original license at the top of the code. If this is another license, then it is unlikely that we can use this code.
3. Again, with the GroovyParticipantExtensionPoint, there is no corresponding exsd file. Did you forget to include it?
4. Your RenameMethodProvider has a reference to the JavaEditor. This will be null if the refactoring is triggered from outside the editor (eg- the package explorer). Also, I'd rather not see that kind of reference in the core part of the code. It looks like the only reason you need to use the JavaEditor is to extract the ITypeRoot from it. I think you should be able to pass the IJavaElement directly into the RenameMethodProvider. This is easy if you are coming from a GroovyEditor. There is a method called getGroovyCompilationUnit(). Or you could always call EditorUtility.getEditorInputJavaElement(this, false); if not in a GroovyEditor.
Let me know if you have any questions.