GRECLIPSE

"Run As->JUnit" sometimes not shown

Details

  • Number of attachments :
    0

Description

We have a JUnit test class in our project for which Run As->JUnit isn't shown. I can't find anything special about this class, it looks just like all the other test classes in the same folder. I can run the test class with cmd+alt+X - T, but not through the context menu.

PS: m2 is still shown under "Unreleased Versions" in JIRA.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Peter Niederwieser added a comment - - edited

Groovy Eclipse 2.0.0.xx-20091207-1900-M2-e35 (same for 2.0.0.xx-20091209-1600-e35)
Groovy 1.7-rc-2

Show
Peter Niederwieser added a comment - - edited Groovy Eclipse 2.0.0.xx-20091207-1900-M2-e35 (same for 2.0.0.xx-20091209-1600-e35) Groovy 1.7-rc-2
Hide
Permalink
Andrew Eisenberg added a comment -

Is this a new bug, or have you seen this under earlier versions as well?

Do you see any exceptions in the error log?

Can you reproduce this on something that you can attach here so I can have a look at it?

Show
Andrew Eisenberg added a comment - Is this a new bug, or have you seen this under earlier versions as well? Do you see any exceptions in the error log? Can you reproduce this on something that you can attach here so I can have a look at it?
Hide
Permalink
Peter Niederwieser added a comment - - edited

I haven't seen this before, but I think this is the first time I tried to run this test from Eclipse. Co-worker tells me that it works for him ((nearly) same versions of Eclipse and Groovy Eclipse). Error log doesn't show any problems. Class has too many dependencies to share it, but I will try to create a stripped-down version. Rebuild/restart doesn't solve the problem.

Show
Peter Niederwieser added a comment - - edited I haven't seen this before, but I think this is the first time I tried to run this test from Eclipse. Co-worker tells me that it works for him ((nearly) same versions of Eclipse and Groovy Eclipse). Error log doesn't show any problems. Class has too many dependencies to share it, but I will try to create a stripped-down version. Rebuild/restart doesn't solve the problem.
Hide
Permalink
Peter Niederwieser added a comment -

I think I've found the problem. In this class, all test methods are marked with:

@Test(expected = SomeException)

It seems there must be at least one @Test without args for Eclipse to recognize the class as a test class.

Show
Peter Niederwieser added a comment - I think I've found the problem. In this class, all test methods are marked with: @Test(expected = SomeException) It seems there must be at least one @Test without args for Eclipse to recognize the class as a test class.
Hide
Permalink
Andrew Eisenberg added a comment -

Thanks for finding this. I think I know exactly where the problem is. When we translate from a groovy ClassNode to a JDT IJavaElement, we convert only the information that is required to get our tools to work. We skip things like comments and certain kinds of annotations.

Currently, the only annotations that we convert are those related to testing (ie- @Test, @Before, @RunWith, etc), but I don't think we have it right.

Show
Andrew Eisenberg added a comment - Thanks for finding this. I think I know exactly where the problem is. When we translate from a groovy ClassNode to a JDT IJavaElement, we convert only the information that is required to get our tools to work. We skip things like comments and certain kinds of annotations. Currently, the only annotations that we convert are those related to testing (ie- @Test, @Before, @RunWith, etc), but I don't think we have it right.
Hide
Permalink
Andrew Eisenberg added a comment -

This is a silly bug, and it should be working. Bumping up the priority.

Show
Andrew Eisenberg added a comment - This is a silly bug, and it should be working. Bumping up the priority.
Hide
Permalink
Andrew Eisenberg added a comment -

OK. Fixed and committed with tests.

The code in the area where annotations are copied over is getting a little sloppy (and I see that in the comments of GroovyCompilationUnitDeclaration.transformAnnotations() ).

Most annotations do not need to be copied over from the groovy world to the JDT world. So far, it seems like only those dealing with JUnit need to. So, we do not need a general solution to copy all annotations and preserving all of their member value pairs is not necessary.

In this case, the member value pair 'expected' is being discarded in the JDT world because it does not appear to be necessary for annotation searching.

Show
Andrew Eisenberg added a comment - OK. Fixed and committed with tests. The code in the area where annotations are copied over is getting a little sloppy (and I see that in the comments of GroovyCompilationUnitDeclaration.transformAnnotations() ). Most annotations do not need to be copied over from the groovy world to the JDT world. So far, it seems like only those dealing with JUnit need to. So, we do not need a general solution to copy all annotations and preserving all of their member value pairs is not necessary. In this case, the member value pair 'expected' is being discarded in the JDT world because it does not appear to be necessary for annotation searching.
Hide
Permalink
Andrew Eisenberg added a comment -

Available in next snapshot release.

Show
Andrew Eisenberg added a comment - Available in next snapshot release.

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Peter Niederwieser
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: