GRECLIPSE

Error compiling closures at class level

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Not A Bug
  • Affects Version/s: 2.0.0m2
  • Fix Version/s: 2.0.0RC1
  • Component/s: Compiler Integration
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    0

Description

This code doesn't compile:

 
    static GroovyCache rabattDescCache = new GroovyCache (Desc.class, 'id') { company, id ->
    }

I get an error marker at "company" saying: Groovy:unexpected token company @line....

GroovyCache is a Java class with this constructor:

 
    public GroovyCache (Class cacheName, String subName, Closure cacheEntryFactory)

When I switch back to the 1.6 compiler by deleting the entry in bundles.info, the project compiles.

I'm not sure whether the bug is in the Eclipse plugin or the 1.7 Groovy compiler. This bug also existed in m1.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andy Clement added a comment -

Are you perhaps being hit by the change in supported syntax from 1.6/1.7 around closures/inner classes. If it also fails on the command line it is a groovy bug, if it does not then it is a groovy eclipse bug.

Show
Andy Clement added a comment - Are you perhaps being hit by the change in supported syntax from 1.6/1.7 around closures/inner classes. If it also fails on the command line it is a groovy bug, if it does not then it is a groovy eclipse bug.
Hide
Permalink
Andy Clement added a comment -

I tried it out on the command line and I get the same failures so it is not groovy eclipse. I do believe it is the changes they have made in 1.7 to the grammar where some old syntax for closures is no longer allowed because of the changes for inner type support. I'm afraid I don't know the other form of closure syntax that will make your test program work - you should ask on the groovy mailing list.

Show
Andy Clement added a comment - I tried it out on the command line and I get the same failures so it is not groovy eclipse. I do believe it is the changes they have made in 1.7 to the grammar where some old syntax for closures is no longer allowed because of the changes for inner type support. I'm afraid I don't know the other form of closure syntax that will make your test program work - you should ask on the groovy mailing list.
Hide
Permalink
Aaron Digulla added a comment -

Okay, thanks. I wasn't sure where to look, so I started at the end of the chain

The workaround is:

static def closure = { company, id ->
    }
static GroovyCache rabattDescCache = new GroovyCache (Desc.class, 'id', closure)

(i.e. define the closure in a statement of its own and then use it in the constructor).

I also agree that this probably broke because if inner type support. You can close this bug.

Show
Aaron Digulla added a comment - Okay, thanks. I wasn't sure where to look, so I started at the end of the chain The workaround is: static def closure = { company, id -> } static GroovyCache rabattDescCache = new GroovyCache (Desc.class, 'id', closure) (i.e. define the closure in a statement of its own and then use it in the constructor). I also agree that this probably broke because if inner type support. You can close this bug.
Hide
Permalink
Andy Clement added a comment -

closing as discussed - it is a groovy change not a greclipse bug.

Show
Andy Clement added a comment - closing as discussed - it is a groovy change not a greclipse bug.

People

  • Assignee:
    Andy Clement
    Reporter:
    Aaron Digulla
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: