[formatting] Need Formatting Fix (using Eclipse's format menu option) for array of closures.

Are you using version 1.6? If so, I recommend that you upgrade. This bug is not fixed in the latest version, but many others are.

I will check at work tomorrow. Thanks.

Also I noticed that JIRA reformatted my description.
I was hoping that each closure in the array would
start on a new line and be indented one "tab".

FYI: I have 1.6.1.20090509195 installed.

Now I have 2.0.0.xx-20091019-1600-M1-e35 and now I do not see the source/format menu option.
Did it go away ;(?

First, I'd recommend upgrading to the latest snapshot because I have done some work on formatting since the M1 release.

Interesting...you're right that the menu option is not there. However, right click in the editor and you should see the Source sub-menu. Also, CTRL-Shift-F will work, too.

Unfortunately, code is still not formatted the way you suggest, but you will have a much better editing experience.

I think there are two issues I need to work on separtely here.

• indentation of stuff inside of lists when split across multiple lines
• formatter (beatifier): having some way to specify cases where lists should be split on multiple lines.
  in this case it should probably use the same rules for "[" and "]" as it uses for " {" and "}

  "

I'll give this a look.

I've adressed the first subtask. So once that patch is committed and a snapshot build, this means you should be able to use the indent (CTRL-I) option.

Next, I'll try to implement something that also handles the formatting option. (Subtask 2).

I'll pay special attention to the case where the list contains closures

This patch provides changes and tests for indentation and formatting of lists.

It should resolve this issue and its two subtasks.

This patch was created against the main trunk of Greclipse (i.e. for Eclipse 3.6).

For some reason, my SVN patch wizard seems to be confused about this file (DefaultGroovyFormatter.java). The patch, no matter what I try here, seems to be wanting to delete this file. But it only has a few small changes in it.

Lacking any better idea on how to get around this, I'm attaching this file alongside the patch.

I recreated this patch in a "clean" workspace. I think this patch should be fine.

I deleted all the previous files to avoid confusion.

Actually, I discovered that my "fix" of this issue broke some other tests. So I've removed this patch until I can address that.

This patch the broken tests. The reason was that expressions inside of for loops are, aparantly also represented as a type of "ListExpression" node in the AST.

Fix is committed.