GRECLIPSE

Bad handling of trivial bug.

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.0alpha
  • Fix Version/s: 2.0.0m1
  • Component/s: None
  • Labels:
    None
  • Environment:
  • Testcase included:
    yes
  • Number of attachments :
    2

Description

I have attached 2 files, TrivialBug.groovy and TrivialBugTest.groovy. The first is a groovy class with a trivial bug.
The second is a groovy junit test which simply creates an instance of the first class. When I run the test I get:

Class not found org.sjb.sjblib.cmdline.TrivialBugTest
java.lang.ClassNotFoundException: org.sjb.sjblib.cmdline.TrivialBugTest
at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
at java.lang.ClassLoader.loadClass(ClassLoader.java:307)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:252)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.loadClass(RemoteTestRunner.java:693)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.loadClasses(RemoteTestRunner.java:429)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:452)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

This is, of course, incorrect. The two classes are in the same directory and it makes no sense that it can find one and
not the other.

I this point I was stumped since the RunAs menu for the file with the error only allowed "GroovyShell" which, as I
have previously reported, doesn't work for me.

Fortunately, I had previously created java's runscript to run my selected file.When I ran the class with the error
this way I got:

script error in file C:\Users\SteveB\EclipseWorkspace2\sjblib\testSrc\org\sjb\sjblib\cmdline\TrivialBug.groovy : org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed, General error during class generation: Cannot use return statement with an expression on a method that returns void.
Node: org.codehaus.groovy.ast.stmt.ReturnStatement. At [11:3] Script1.groovy

org.codehaus.groovy.syntax.RuntimeParserException: Cannot use return statement with an expression on a method that returns void.
Node: org.codehaus.groovy.ast.stmt.ReturnStatement. At [11:3] Script1.groovy
at org.codehaus.groovy.classgen.AsmClassGenerator.throwException(AsmClassGenerator.java:1543)
at org.codehaus.groovy.classgen.AsmClassGenerator.visitReturnStatement(AsmClassGenerator.java:1249)
at org.codehaus.groovy.ast.stmt.ReturnStatement.visit(ReturnStatement.java:47)
at org.codehaus.groovy.ast.CodeVisitorSupport.visitBlockStatement(CodeVisitorSupport.java:38)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitBlockStatement(ClassCodeVisitorSupport.java:129)
at org.codehaus.groovy.classgen.AsmClassGenerator.visitBlockStatement(AsmClassGenerator.java:676)
at org.codehaus.groovy.ast.stmt.BlockStatement.visit(BlockStatement.java:52)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitClassCodeContainer(ClassCodeVisitorSupport.java:73)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitConstructorOrMethod(ClassCodeVisitorSupport.java:80)
at org.codehaus.groovy.classgen.AsmClassGenerator.visitStdMethod(AsmClassGenerator.java:553)
at org.codehaus.groovy.classgen.AsmClassGenerator.visitConstructorOrMethod(AsmClassGenerator.java:529)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitMethod(ClassCodeVisitorSupport.java:88)
at org.codehaus.groovy.classgen.AsmClassGenerator.visitMethod(AsmClassGenerator.java:633)
at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1008)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitClass(ClassCodeVisitorSupport.java:48)
at org.codehaus.groovy.classgen.AsmClassGenerator.visitClass(AsmClassGenerator.java:243)
at org.codehaus.groovy.control.CompilationUnit$10.call(CompilationUnit.java:717)
at org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:924)
at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:462)
at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:278)
at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:249)
at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:244)
at org.codehaus.groovy.jsr223.GroovyScriptEngineImpl.getScriptClass(GroovyScriptEngineImpl.java:321)
at org.codehaus.groovy.jsr223.GroovyScriptEngineImpl.eval(GroovyScriptEngineImpl.java:113)
at org.codehaus.groovy.jsr223.GroovyScriptEngineImpl.eval(GroovyScriptEngineImpl.java:107)
at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:232)
at com.sun.tools.script.shell.Main.evaluateReader(Main.java:314)
at com.sun.tools.script.shell.Main.evaluateStream(Main.java:350)
at com.sun.tools.script.shell.Main.processSource(Main.java:267)
at com.sun.tools.script.shell.Main.access$100(Main.java:19)
at com.sun.tools.script.shell.Main$2.run(Main.java:182)
at com.sun.tools.script.shell.Main.main(Main.java:30)

1 error

At the end of the first, incredibly long, line (folded above) is the actual error. I don't know how a typical user
is suppossed to debug this trivial error. I spent a lot of time fooling with the classpath in the launch script
when I thought of trying runscript.

I doubt whether this has to do with the particular trivial error. It is probably more general. You should try other
errors that java would
catch at compile time but groovy doesn't catch until run time.

  1. File
    TrivialBug.groovy
    18/Sep/09 2:56 PM
    0.1 kB
    Steve Buroff
  2. File
    TrivialBugTest.groovy
    18/Sep/09 2:56 PM
    0.2 kB
    Steve Buroff

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andy Clement added a comment -

When I define your two files in a project, although I see no hard error in the problems view or editor window, I do see a compiler problem reported as a warning - both in the problems view and the editor window. In the editor it is recorded against the first line of the file (in TrivialBug.groovy). Do you see this warning?

It seems the problem is that for some reason the message from groovyc is being reported as a warning when it should be more serious than that.

Show
Andy Clement added a comment - When I define your two files in a project, although I see no hard error in the problems view or editor window, I do see a compiler problem reported as a warning - both in the problems view and the editor window. In the editor it is recorded against the first line of the file (in TrivialBug.groovy). Do you see this warning? It seems the problem is that for some reason the message from groovyc is being reported as a warning when it should be more serious than that.
Hide
Permalink
Steve Buroff added a comment -

I don't recall seeing any compile time warnings. However, even if they were there it doesn't matter.
If there is an error at run time there should be a useful message, not a misleading one.

Show
Steve Buroff added a comment - I don't recall seeing any compile time warnings. However, even if they were there it doesn't matter. If there is an error at run time there should be a useful message, not a misleading one.
Hide
Permalink
Andy Clement added a comment -

I didn't say there should not be a useful message. But if I make the fix I plan to, which is to make the warning a hard error, and yet you were never seeing the warning, then I won't have fixed your problem.

Show
Andy Clement added a comment - I didn't say there should not be a useful message. But if I make the fix I plan to, which is to make the warning a hard error, and yet you were never seeing the warning, then I won't have fixed your problem.
Hide
Permalink
Andy Clement added a comment -

after making the warning a hard error, I see some extra wierdness. Although the error is correctly recorded against the type 'TrivialBug', it is also recorded against the type TrivialBugTest. I believe this is down to driving all the files through a phase together. Because this problem causes TrivialBug not to make it to the next phase, when we compile TrivialBugTest we also make another attempt to get TrivialBug through to the next phase. I'm surprised we aren't seeing more problems like this where an error is recorded against too many compilation results.

Show
Andy Clement added a comment - after making the warning a hard error, I see some extra wierdness. Although the error is correctly recorded against the type 'TrivialBug', it is also recorded against the type TrivialBugTest. I believe this is down to driving all the files through a phase together. Because this problem causes TrivialBug not to make it to the next phase, when we compile TrivialBugTest we also make another attempt to get TrivialBug through to the next phase. I'm surprised we aren't seeing more problems like this where an error is recorded against too many compilation results.
Hide
Permalink
Andy Clement added a comment -

Fixed. Promoted the warning to a hard error by adding support in the error processing code for RuntimeParserException instances. Also modified the error handling to deal try and ensure errors aren't recorded twice or against the wrong ModuleNode. I've only done this latter change for RuntimeParserExceptions - it may occur for other kinds of error too (surely it does? I've left an M2 TODO to look into it)

The fix will be in a build shortly (next couple of hours).

Show
Andy Clement added a comment - Fixed. Promoted the warning to a hard error by adding support in the error processing code for RuntimeParserException instances. Also modified the error handling to deal try and ensure errors aren't recorded twice or against the wrong ModuleNode. I've only done this latter change for RuntimeParserExceptions - it may occur for other kinds of error too (surely it does? I've left an M2 TODO to look into it) The fix will be in a build shortly (next couple of hours).

People

  • Assignee:
    Andy Clement
    Reporter:
    Steve Buroff
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: