GRECLIPSE

"<ctrl>2 r" doesn't work correctly

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: None
  • Fix Version/s: 2.0.0RC1
  • Component/s: None
  • Labels:
    None
  • Environment:
  • Number of attachments :
    0

Description

"<ctrl>2 r" doesn't work correctly For example if I have a method and I change an argument name, only the argument name is changed. The name in the body of the method and in the method's javadoc comment are not changed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andy Clement added a comment -

at least define the limitations here for M1. Even if we cannot fix it in that timeframe.

Show
Andy Clement added a comment - at least define the limitations here for M1. Even if we cannot fix it in that timeframe.
Hide
Permalink
Andrew Eisenberg added a comment -

Here the problem is that rename is going through a different entry point than other refactorings. This is activating the quick assist rename, rather than the refactor rename.

For refactor rename, we are executing the groovy rename functionality, but quick assist rename is executing the jdt rename, which will not work properly in groovy files.

Need to figure out how to usurp quick assists so that the groovy rename is executed instead.

Show
Andrew Eisenberg added a comment - Here the problem is that rename is going through a different entry point than other refactorings. This is activating the quick assist rename, rather than the refactor rename. For refactor rename, we are executing the groovy rename functionality, but quick assist rename is executing the jdt rename, which will not work properly in groovy files. Need to figure out how to usurp quick assists so that the groovy rename is executed instead.
Hide
Permalink
Steve Buroff added a comment - - edited

Just to note, I think the quick assist and the refactoring are not the same. The quick assist,
"<ctrl>2-R", works only on the current file - useful for local variables and private fields and
method names.

The refactoring, "<alt><shft>R", works on the entire project.

Correct me if I'm wrong but that's the way I think it works for Java.

BTW, what's up with the JIRA server? Its been terribly slow yesterday and today. Note the
timeout above.

Show
Steve Buroff added a comment - - edited Just to note, I think the quick assist and the refactoring are not the same. The quick assist, "<ctrl>2-R", works only on the current file - useful for local variables and private fields and method names. The refactoring, "<alt><shft>R", works on the entire project. Correct me if I'm wrong but that's the way I think it works for Java. BTW, what's up with the JIRA server? Its been terribly slow yesterday and today. Note the timeout above.
Hide
Permalink
Andrew Eisenberg added a comment -

Delaying this until M2. No exceptions are thrown, and since only the formal parameter itself is changed, it is easy to see that the refactoring did not work.

BTW- javadoc refactoring will be very hard to do because javadoc is not currently parsed by the groovy compiler.

Show
Andrew Eisenberg added a comment - Delaying this until M2. No exceptions are thrown, and since only the formal parameter itself is changed, it is easy to see that the refactoring did not work. BTW- javadoc refactoring will be very hard to do because javadoc is not currently parsed by the groovy compiler.
Hide
Permalink
Andrew Eisenberg added a comment -

Not going to fix for M2.

Show
Andrew Eisenberg added a comment - Not going to fix for M2.
Hide
Permalink
Andrew Eisenberg added a comment -

Closing this bug. Not going to fix it. The exception is no longer thrown and rename refactoring is possible.

Post 2.0 release, we will work on quick assists and re-enabling this quick assist would be a good idea.

Show
Andrew Eisenberg added a comment - Closing this bug. Not going to fix it. The exception is no longer thrown and rename refactoring is possible. Post 2.0 release, we will work on quick assists and re-enabling this quick assist would be a good idea.

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Steve Buroff
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: