[formatting] Improvements for code formatter

Hi Jean-Noël

Thanks for your feedback. A comment to the behavior of the formatter. There are two strategies which are working together. A "beautifier" an an "Indentor" The Beautifier tries to combine simple closures, with only one statement, to one line closures. I'm working on the feature, that the user can specify when this reduce to one line should be done.

If you only like to get the Indentation to be fixed use the specific function for this. Ctrl + I

Will look at this for 2.0.2.

I am planning on taking a serious look at the code formatter and indentor.

I believe some work has gone into the formatter since this issue was create, so I am trying to get a sense of where we stand.

When I try the given example it now gets formatted like this:

		result.getFailures().each {
			def testHeader = it.getTestHeader()
			def currentTestName = testHeader.substring(testHeader.indexOf("(") + 1, testHeader.indexOf(")"))
			println testHeader
			it.getTrace().split("\n").eachWithIndex { line, i ->
				if (line.contains(currentTestName) || 0 == i) {
					println line
				}
			}
		}

This doesn't seem so bad. In particular it doesn't seem to have the issue with how closures after .each are being indented.

Jean Noel, can you confirm that this particular example indents/formats satisfactorily for you, so I can close this issue. Alternatively, explain what you think is still a problem and or post/further examples.

Thanks

PS: I'm sure the formatter still needs a lot of work, but I'd like to close this particular issue and look at other formatter related problems.

Hello. Are you a new SpringSource employee working on the plugin? That would be great

Anyway, I had a look at that today. A very simple class does not get formatted at all when I hit Format.

class EmailCommand
{
	String email
	String messageContent

	static constraints =
	{
		email("email": true, "blank": false)
		messageContent("blank": false)
	}

	void fun()
	{
		def a = [3]
		a.each
				{
				println it

			}



	}
}

The funny thing is that if I had the sample code with result.getFailures() inside the fun method, formatting still does not appear. If I put it below the method (in a place where it clearly is illegal, the formatting happens, even for the fun method, and my initial behavior is observed.

In my experience, the formatting for Groovy is so badly broken that we should continue this conversation via email or even better, instant messaging. Let me just say that for me formatting is not working at all, and this needs a lot of fixing to get to a working state.

Hi Jean Noel,

Yes I'm a new SpringSource employee and right now I've got a whole bunch of GReclipse formatting related issues in Jira assigned to me. So it looks like I'll be working on getting the formatter in a less broken state...

Yes, I agree the formatter needs a lot of work. Precisely for this reason, I'd rather keep stuff related to any issues that need fixing in Jira, rather than chat/email. That way its much easier to track what still needs fixing. My wanting to close this issue doesn't mean that I think formatting is now "fixed". Only that the example in this issue is no longer causing problems.

I'd be happy for you to put more comments an examples that break for you here in this Jira issue or a new one.

The example you just posted is exactly what I need, some code snippet that breaks the formatter (I checked on my end and can reproduce the effects you describe). So, I'll keep this issue open for as long as their are broken examples in here .

Cheers,

Kris

OK. I can probably give you issues to fix for at least one year of hard work so don't worry, once you got over this one I will have more for you

This is probably OK for me (although I think the compact small closures feature should be kept as a configuration option). Normally I use the opening brace in a new line but this should work OK on my system as this is configurable.
I'll download the new snapshot, see if it works, and open more JIRA issues once I know this one is OK.

Updated patch to reflect that test files where moved into resources directory.

Patch applied and committed. Thanks.

The fix is now in the latest snapshot build. Available from the snapshot update site

http://dist.codehaus.org/groovy/distributions/greclipse/snapshot/e3.5/

Resolving this issue, since I think the examples in this issue should now all work correctly.

I am going to create another Jira issue about putting back support for "compact closures".