GRECLIPSE

Problem configuring groovy classloader classpath (not using groovy.properties)

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: 2.7.0.Release
  • Fix Version/s: 2.7.1.Release
  • Component/s: Compiler Integration
  • Labels:
    None
  • Number of attachments :
    3

Description

Eclipse continues to show this output on stdout:

Problem configuring groovy classloader classpath (not using groovy.properties)
java.lang.NullPointerException
	at org.eclipse.jdt.core.util.CompilerUtils.pathToString(CompilerUtils.java:194)
	at org.eclipse.jdt.core.util.CompilerUtils.calculateClasspath(CompilerUtils.java:210)
	at org.eclipse.jdt.core.util.CompilerUtils.setGroovyClasspath(CompilerUtils.java:152)
	at org.eclipse.jdt.core.util.CompilerUtils.setGroovyClasspath(CompilerUtils.java:117)
	at org.codehaus.jdt.groovy.model.GroovyCompilationUnit.buildStructure(GroovyCompilationUnit.java:260)
	at org.eclipse.jdt.internal.core.Openable.generateInfos(Openable.java:258)
	at org.eclipse.jdt.internal.core.JavaElement.openWhenClosed(JavaElement.java:526)
	at org.eclipse.jdt.internal.core.BecomeWorkingCopyOperation.executeOperation(BecomeWorkingCopyOperation.java:38)
	at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:728)
	at org.eclipse.jdt.internal.core.JavaModelOperation.runOperation(JavaModelOperation.java:788)
	at org.eclipse.jdt.internal.core.CompilationUnit.becomeWorkingCopy(CompilationUnit.java:101)
...
  1. File
    .classpath
    01/Aug/12 3:55 AM
    1.0 kB
    Jörg Thönnes
  2. File
    .project
    01/Aug/12 3:56 AM
    0.7 kB
    Jörg Thönnes
  3. Text File
    Eclipse-stacktrace.txt
    26/Jul/12 5:15 AM
    7 kB
    Jörg Thönnes

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jörg Thönnes added a comment -

Attached complete Eclipse stack trace output.

This occurs several times.

Show
Jörg Thönnes added a comment - Attached complete Eclipse stack trace output. This occurs several times.
Hide
Permalink
Jörg Thönnes added a comment -

Eclipse version 3.7.2 with Mylyn 3.8, GRECLIPSE 2.7.0

Show
Jörg Thönnes added a comment - Eclipse version 3.7.2 with Mylyn 3.8, GRECLIPSE 2.7.0
Hide
Permalink
Andrew Eisenberg added a comment -

I can definitely add a null check to avoid this NPE, but I'd prefer to figure out what the cause of the problem is. Do you know which project is causing the exception? Can you attach the .project file and the .classpath file for this project? (They are hidden files in the root of the project.)

Show
Andrew Eisenberg added a comment - I can definitely add a null check to avoid this NPE, but I'd prefer to figure out what the cause of the problem is. Do you know which project is causing the exception? Can you attach the .project file and the .classpath file for this project? (They are hidden files in the root of the project.)
Hide
Permalink
Jörg Thönnes added a comment -

Hello Andrew,

sorry for answering so late – was busy and will be unavailable for the next 3 weeks.

Please find attached the .classpath and .project files.

Cheers, Jörg

Show
Jörg Thönnes added a comment - Hello Andrew, sorry for answering so late – was busy and will be unavailable for the next 3 weeks. Please find attached the .classpath and .project files. Cheers, Jörg
Hide
Permalink
Jörg Thönnes added a comment -

Attached .project file.

Show
Jörg Thönnes added a comment - Attached .project file.
Hide
Permalink
Jörg Thönnes added a comment -

If you have any questions – I might check this ticket for the next 2-3 days.

Show
Jörg Thönnes added a comment - If you have any questions – I might check this ticket for the next 2-3 days.
Hide
Permalink
Andrew Eisenberg added a comment -

Thanks for the extra attachments.

It looks like the only way there can be an NPE at CompilerUtils.java:194 is if the project is closed or doesn't exist. If this is the case, then I'm not sure why the file is being sent to the compiler. I see from the stack trace that this exception occurred while in the compare editor. Perhaps you somehow have an editor open that is trying to compare a file that is located in a closed project. This is just a hunch. Is this something that makes sense to you?

I will add the null check and commit it.

Show
Andrew Eisenberg added a comment - Thanks for the extra attachments. It looks like the only way there can be an NPE at CompilerUtils.java:194 is if the project is closed or doesn't exist. If this is the case, then I'm not sure why the file is being sent to the compiler. I see from the stack trace that this exception occurred while in the compare editor. Perhaps you somehow have an editor open that is trying to compare a file that is located in a closed project. This is just a hunch. Is this something that makes sense to you? I will add the null check and commit it.
Hide
Permalink
Andrew Eisenberg added a comment -

I committed a null pointer check that should hopefully avoid the NPE that you are seeing. My assumption, as I mentioned in my previous comment is that the project that is causing this error is either closed or deleted even though you have an editor still open with the file you are working on.

Show
Andrew Eisenberg added a comment - I committed a null pointer check that should hopefully avoid the NPE that you are seeing. My assumption, as I mentioned in my previous comment is that the project that is causing this error is either closed or deleted even though you have an editor still open with the file you are working on.
Hide
Permalink
Andrew Eisenberg added a comment -

New build is available for 3.7 and 4.2. Please update using the snapshot update site when you can and provide feedback if this is working for you.

Show
Andrew Eisenberg added a comment - New build is available for 3.7 and 4.2. Please update using the snapshot update site when you can and provide feedback if this is working for you.
Hide
Permalink
Jörg Thönnes added a comment -

Thanks, Andrew. I am on vacation now and will be able to check in 3 weeks.

Show
Jörg Thönnes added a comment - Thanks, Andrew. I am on vacation now and will be able to check in 3 weeks.
Hide
Permalink
Andrew Eisenberg added a comment -

Thanks. Please keep us posted.

Show
Andrew Eisenberg added a comment - Thanks. Please keep us posted.
Hide
Permalink
Jörg Thönnes added a comment -

Sorry, Andrew for not responding timely. I was on holiday and in the meanwhile we have upgraded our installation to Eclipse 3.8.

If I see this issue again (did not happen since I reported it), I will test with the snapshot provided by you.

Show
Jörg Thönnes added a comment - Sorry, Andrew for not responding timely. I was on holiday and in the meanwhile we have upgraded our installation to Eclipse 3.8. If I see this issue again (did not happen since I reported it), I will test with the snapshot provided by you.
Hide
Permalink
Andrew Eisenberg added a comment -

Closing this issue for now. But I will reopen if you experience again.

Show
Andrew Eisenberg added a comment - Closing this issue for now. But I will reopen if you experience again.
Hide
Permalink
Rafael Chaves added a comment -

I can reproduce this reliably on a new workspace with a new Grails project using Groovy/Grails Tool Suite 3.0.0.RELEASE (Build Id: 201208091018),

Andrew, do you know if your fix got in that build?

Steps to reproduce:
1) on a grails project, show the local history for a Groovy file (if there is no history yet, make some edits, save and try again)
2) in the history view, right click one of the entries and select "Compare Current with Local" (make sure you didn't have the compare editor open for that file)

Show
Rafael Chaves added a comment - I can reproduce this reliably on a new workspace with a new Grails project using Groovy/Grails Tool Suite 3.0.0.RELEASE (Build Id: 201208091018), Andrew, do you know if your fix got in that build? Steps to reproduce: 1) on a grails project, show the local history for a Groovy file (if there is no history yet, make some edits, save and try again) 2) in the history view, right click one of the entries and select "Compare Current with Local" (make sure you didn't have the compare editor open for that file)
Hide
Permalink
Andrew Eisenberg added a comment -

This fix did not make it into GGTS 3.0.0, which included Groovy-Eclipse 2.7.0. You can upgrade to 2.7.1 from the update site:

http://dist.springsource.org/release/GRECLIPSE/e4.2/

I think it is included in GGTS by default.

I tried your steps on the latest snapshot and could not reproduce. If you still see this problem after upgrading, then I will have a deeper look.

Show
Andrew Eisenberg added a comment - This fix did not make it into GGTS 3.0.0, which included Groovy-Eclipse 2.7.0. You can upgrade to 2.7.1 from the update site: http://dist.springsource.org/release/GRECLIPSE/e4.2/ I think it is included in GGTS by default. I tried your steps on the latest snapshot and could not reproduce. If you still see this problem after upgrading, then I will have a deeper look.
Hide
Permalink
Rafael Chaves added a comment - - edited

Thanks. At least now you know how the problem would have occurred. I confirmed the issue doesn't happen in 2.7.1.

Show
Rafael Chaves added a comment - - edited Thanks. At least now you know how the problem would have occurred. I confirmed the issue doesn't happen in 2.7.1.
Hide
Permalink
Andrew Eisenberg added a comment - - edited

Thanks for verifying the fix. And now that I think about it a bit, this makes sense based on the original implementation. We had expected that we would always be compiling a file (or at least something traceable to disk). In this case, however, we are trying to compile a diff-ed version. And so we cannot configure the groovy classloader in the same way. The fix makes sense as I see it.

Show
Andrew Eisenberg added a comment - - edited Thanks for verifying the fix. And now that I think about it a bit, this makes sense based on the original implementation. We had expected that we would always be compiling a file (or at least something traceable to disk). In this case, however, we are trying to compile a diff-ed version. And so we cannot configure the groovy classloader in the same way. The fix makes sense as I see it.

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Jörg Thönnes
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: