GRECLIPSE

Problems with FindSurroundingNode

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6.1.Release
  • Fix Version/s: 2.7.0.Release
  • Component/s: Search
  • Labels:
    None
  • Number of attachments :
    0

Description

There are some problems with the FindSurroundingNode class. It fails to find nodes that are inside prefix or postfix expressions. This is because of a misplaced super call in some of the visit methods.

I have a fix and am almost through writing the tests.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Eisenberg added a comment - - edited

GRECLIPSE-1425 describes some bugs in the source locations that I discovered while working on the tests.

Show
Andrew Eisenberg added a comment - - edited GRECLIPSE-1425 describes some bugs in the source locations that I discovered while working on the tests.
Hide
Permalink
Andrew Eisenberg added a comment -

Committed the fix with regression tests. No regression tests for he elvis and ternary operators since they are still broken under GRECLIPSE-1425.

Show
Andrew Eisenberg added a comment - Committed the fix with regression tests. No regression tests for he elvis and ternary operators since they are still broken under GRECLIPSE-1425 .

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Andrew Eisenberg
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: