GRECLIPSE

Wrong syntax highlighting when a method parameter named "owner" is referenced within the body of a closure used inside that method

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.6.1.M1
  • Fix Version/s: 2.8.0.Release
  • Component/s: Inferencing Engine
  • Labels:
    None
  • Number of attachments :
    0

Description

Consider the following interface:

package test;

public interface I
{
	String getProp();
}

and the following Groovy class:

package test

class A {
	String myMethod(I owner) {
		doNothing { return owner.prop }
	}

	Object doNothing(Closure<Object> c) {
		return c.call()
	}
}

Look at the body of myMethod. The prop property of owner is underlined because at that point owner is not recognized as the "owner" method parameter of myMethod: the parser seems to think it's the owner of the closure, although the "mark occurences" and the "go to declaration" features work correctly.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mauro Molinari added a comment - - edited

Please note that also the code assist is wrong just like the highlighting: if you try to invoke code assist at owner.| at that line, the "prop" property is not proposed.

Show
Mauro Molinari added a comment - - edited Please note that also the code assist is wrong just like the highlighting: if you try to invoke code assist at owner.| at that line, the "prop" property is not proposed.
Hide
Permalink
Andrew Eisenberg added a comment -

Interesting...didn't know that this was possible...

Show
Andrew Eisenberg added a comment - Interesting...didn't know that this was possible...
Andrew Eisenberg made changes -
Field Original Value New Value
Component/s Inferencing Engine [ 14687 ]
Component/s Parser [ 15153 ]
Andrew Eisenberg made changes -
Fix Version/s 2.8.0.Release [ 18618 ]
Andrew Eisenberg made changes -
Assignee Andrew Eisenberg [ werdna ]
Hide
Permalink
Andrew Eisenberg added a comment -

The inferencing engine is inferring the wrong owner. It is thinking it is coming from the closure, not as a parameter.

Show
Andrew Eisenberg added a comment - The inferencing engine is inferring the wrong owner . It is thinking it is coming from the closure, not as a parameter.
Hide
Permalink
Andrew Eisenberg added a comment -

Partial fix implemented for both owner and delegate. Working as expected for single closures, but not for nested closures. Eg-

	String myMethod(I owner) {
		doNothing { return { return owner.prop } }
	}

The reference to owner is incorrectly inferred to be Closure, which is correct if there were no owner parameter.

Show
Andrew Eisenberg added a comment - Partial fix implemented for both owner and delegate . Working as expected for single closures, but not for nested closures. Eg- String myMethod(I owner) { doNothing { return { return owner.prop } } } The reference to owner is incorrectly inferred to be Closure , which is correct if there were no owner parameter.

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Mauro Molinari
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: