GRECLIPSE

Allow "Open Declaration" / CTRL+ Click / F3 on GString expressions without braces

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.6.1.Release
  • Component/s: Editor, Search
  • Labels:
    None
  • Number of attachments :
    0

Description

In the following script, the variable i cannot be navigated to by "Open Declaration":

def i = 1
def s = "$i"

However, it works as expected with the following:

def i = 1
def s = "${i}"

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Eisenberg added a comment -

I just tried this. I am bumping this down to minor since looks like this only happens for variables that are 1 char long. If I rename the variable to ii, then things work as expected.

I'll see if there is an easy fix anyway.

Show
Andrew Eisenberg added a comment - I just tried this. I am bumping this down to minor since looks like this only happens for variables that are 1 char long. If I rename the variable to ii , then things work as expected. I'll see if there is an easy fix anyway.
Hide
Permalink
Andrew Eisenberg added a comment - - edited

Actually, for mark occurrences, there was a bit more of an issue since the editor was considering the '$' to be part of the variable name, which was messing things up and I fixed this as well.

Fixed with regression tests.

Show
Andrew Eisenberg added a comment - - edited Actually, for mark occurrences, there was a bit more of an issue since the editor was considering the '$' to be part of the variable name, which was messing things up and I fixed this as well. Fixed with regression tests.
Hide
Permalink
Bob Tiernay added a comment -

Although F3 and "Open Declaration" seem to work, CTRL + Clicking does not.

Show
Bob Tiernay added a comment - Although F3 and "Open Declaration" seem to work, CTRL + Clicking does not.
Hide
Permalink
Bob Tiernay added a comment -

Reopening to see if this is still an issue.

Show
Bob Tiernay added a comment - Reopening to see if this is still an issue.
Hide
Permalink
Andrew Eisenberg added a comment -

Not able to reproduce with the example given. Please provide a failing test, and I'll look into this again.

Show
Andrew Eisenberg added a comment - Not able to reproduce with the example given. Please provide a failing test, and I'll look into this again.
Hide
Permalink
Bob Tiernay added a comment -

I just verified that this still does not work for me on 2.6.1.xx-20120213-1100-e37

def variable = 1
def text = "$variable" // Cannot navigate to def variable by CTRL + Clicking on "$variable"
Show
Bob Tiernay added a comment - I just verified that this still does not work for me on 2.6.1.xx-20120213-1100-e37 def variable = 1 def text = "$variable" // Cannot navigate to def variable by CTRL + Clicking on "$variable"
Hide
Permalink
Andrew Eisenberg added a comment -

OK...now you got it.

Looks like the problem is that when there are no curlies, navigation doesn't work, but it does when the curlies exist.

Show
Andrew Eisenberg added a comment - OK...now you got it. Looks like the problem is that when there are no curlies, navigation doesn't work, but it does when the curlies exist.
Hide
Permalink
Andrew Eisenberg added a comment -

More specifically, the problem is that the selection is calculated differently based on whether CTRL+Click is used vs F3. For F3, the caret location is used as the selection to analyze, but CTRL+Click takes the character under the mouse pointer and expands that to be the entire word. In this case, the word includes the trailing $, since that is a valid identifier part.

Either, I need to change the selection before analyzing it, or I need to ensure that the code selection visitor can handle trailing $ inside of GStrings.

Show
Andrew Eisenberg added a comment - More specifically, the problem is that the selection is calculated differently based on whether CTRL+Click is used vs F3. For F3, the caret location is used as the selection to analyze, but CTRL+Click takes the character under the mouse pointer and expands that to be the entire word. In this case, the word includes the trailing $, since that is a valid identifier part. Either, I need to change the selection before analyzing it, or I need to ensure that the code selection visitor can handle trailing $ inside of GStrings.
Hide
Permalink
Andrew Eisenberg added a comment -

Fixed for real this time. Available in next snapshot build.

Show
Andrew Eisenberg added a comment - Fixed for real this time. Available in next snapshot build.

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Bob Tiernay
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: