GRECLIPSE

Implement the closestEnclosingCallName pointcut

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.6.0.Release
  • Fix Version/s: 2.8.0.Release
  • Component/s: DSL Support
  • Labels:
    None
  • Number of attachments :
    0

Description

IN GRECLIPSE-1298, we discussed the possibility of a closestEnclosingCallName. This pointcut matches on the name of the closest enclosing call, even if there are multiply nested calls. For completeness, we should also implement closestEnclosingCall. I don't know if I like the name of these pointcuts, and before I implement, I want to be sure that it would address the problem described in GRECLIPSE-1298.

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. GRECLIPSE-1298 Allow DSLD to define the 'delegate' type for a particular closure

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Andrew Eisenberg made changes -
Field Original Value New Value
Link This issue relates to GRECLIPSE-1298 [ GRECLIPSE-1298 ]
Hide
Permalink
Bob Tiernay added a comment - - edited

Hi Andrew,

Thanks for addressing this. I think this pointcut would be a valuable addition. In terms of naming, I'm not sure what makes the most sense but I can live with the names you suggest. They seem intuitive.

Not sure if you are trying to align with AspectJ in general for the DSLD language. I realize groovy has its own join point model, and that DSLD doesn't make sense for a lot of AspectJ pointcuts (ie non-lexical) but it may be something worth considering.

Show
Bob Tiernay added a comment - - edited Hi Andrew, Thanks for addressing this. I think this pointcut would be a valuable addition. In terms of naming, I'm not sure what makes the most sense but I can live with the names you suggest. They seem intuitive. Not sure if you are trying to align with AspectJ in general for the DSLD language. I realize groovy has its own join point model, and that DSLD doesn't make sense for a lot of AspectJ pointcuts (ie non-lexical) but it may be something worth considering.
Andrew Eisenberg made changes -
Fix Version/s 2.7.0.Release [ 18349 ]
Fix Version/s 2.6.1.Release [ 18147 ]
Andrew Eisenberg made changes -
Fix Version/s 2.7.1.Release [ 18617 ]
Fix Version/s 2.7.0.Release [ 18349 ]
Andrew Eisenberg made changes -
Fix Version/s 2.7.2.Release [ 18821 ]
Fix Version/s 2.7.1.Release [ 18617 ]
Andrew Eisenberg made changes -
Fix Version/s 2.8.0.Release [ 18618 ]
Fix Version/s 2.7.2.Release [ 18821 ]

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Andrew Eisenberg
Vote (1)
Watch (1)

Dates

  • Created:
    Updated: