GRECLIPSE

The type of - on collections looses element info

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6.0.Release
  • Fix Version/s: 2.6.1.Release
  • Component/s: Inferencing Engine
  • Labels:
    None
  • Number of attachments :
    0

Description

class Bingo {
	
	
	def foo() {
		def x = [ "a", "ab", "bc"]
		def z = x - x
	}

}

Type of z is List<Object>... should be List<String>

In general I think one shoul assume the elements to be of the same type as the elements in the first collection. Since you are removing elements from the list, so it can at most have the same elements as in the original collection.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Eisenberg added a comment -

This is one of the things I have been working on.

Show
Andrew Eisenberg added a comment - This is one of the things I have been working on.
Hide
Permalink
Andrew Eisenberg added a comment -

The problem here is that we don't do anything with type parameters on methods. And the minus method is declared using a type parameter.

I can work something special for this case, because it is common, but I need a more robust solution for method type parameters. See also GRECLIPSE-1129.

Show
Andrew Eisenberg added a comment - The problem here is that we don't do anything with type parameters on methods. And the minus method is declared using a type parameter. I can work something special for this case, because it is common, but I need a more robust solution for method type parameters. See also GRECLIPSE-1129 .
Hide
Permalink
Andrew Eisenberg added a comment -

Fixed and committed with regression tests.

I special cased + and - on list types as well as on numbers and strings. For Strings, we have a hard time picking out the right variant from DefaultGroovyMethods. For lists, there is a type parameter on the plus and minus methods. And for numbers, they avoid dynamic dispatch altogether.

Show
Andrew Eisenberg added a comment - Fixed and committed with regression tests. I special cased + and - on list types as well as on numbers and strings. For Strings, we have a hard time picking out the right variant from DefaultGroovyMethods. For lists, there is a type parameter on the plus and minus methods. And for numbers, they avoid dynamic dispatch altogether.

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Kris De Volder
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: