GRECLIPSE

DSLD suggstion for "isThisType" is wrong

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.6.1.Release
  • Component/s: DSL Support
  • Labels:
    None
  • Number of attachments :
    0

Description

Open any DSLD file. Type "isThisType" and CTRL-SPACE. Suggestion will add an argument. However trying to actually use 'isThisType' with an argument will result in an error. The error states that isThisType shouldn't be used with arguments.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. GRECLIPSE-1292 isThisType pointcut not correct in DSLD

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Eisenberg added a comment -

Yes. The problem is that we are comparing the current type to the enclosing type declaration. Rather, we should be comparing the current type to this type. the enclosing type declaration can be different from this when inside of a closure.

Easy fix to make. I think it is OK to change the semantics here. There already is another pointcut currentTypeIsEnclosingType, it has the same semantics as isThisType, but is deprecated. We should keep both pointcuts and provide them with different semantics.

Show
Andrew Eisenberg added a comment - Yes. The problem is that we are comparing the current type to the enclosing type declaration. Rather, we should be comparing the current type to this type. the enclosing type declaration can be different from this when inside of a closure. Easy fix to make. I think it is OK to change the semantics here. There already is another pointcut currentTypeIsEnclosingType , it has the same semantics as isThisType , but is deprecated. We should keep both pointcuts and provide them with different semantics.
Hide
Permalink
Andrew Eisenberg added a comment -

Fixed with regression tests.

Show
Andrew Eisenberg added a comment - Fixed with regression tests.

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Kris De Volder
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: