Details
-
Type:
Bug
-
Status:
Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.5.2.Release
-
Fix Version/s: 2.6.1.M1
-
Labels:
-
Patch Submitted:Yes
-
Number of attachments :
Description
Seems like the work in GRECLIPSE-1233 is not complete. Mark occurrences is not correct when there are default parameter references coming from other files. Eg-
class C {
def xxx(a, b = 2) {}
}
and in another file:
def obj new C().xxx() new C().xxx(obj) new C().xxx(obj, obj) new C().xxx(obj, obj, obj)
Select the first, third or fourth method reference and the first, third, and fourth reference highlights. Select the second, and only the second highlights.
The correct behavior is that selecting any method reference should select all other references. This is the behavior that you see when all are inside the same file.
Issue Links
- is related to
-
GRECLIPSE-1256
Use a classfile attribute in the classfile to help determine the original method declaration of a method that uses default parameters
-
Activity
Andrew Eisenberg
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Labels | help-requested |
Andrew Eisenberg
made changes -
| Description |
Seems like the work in {code} class C { def xxx(a, b = 2) {} } {code} and in another file: {code} def obj new C().xxx() new C().xxx(obj) new C().xxx(obj, obj) new C().xxx(obj, obj, obj) {code} Select the first, third or fourth method reference and the first, third, and fourth reference highlights. Select the second, and only the second highlights. The correct behavior is that selecting any method reference should select all other references. |
Seems like the work in {code} class C { def xxx(a, b = 2) {} } {code} and in another file: {code} def obj new C().xxx() new C().xxx(obj) new C().xxx(obj, obj) new C().xxx(obj, obj, obj) {code} Select the first, third or fourth method reference and the first, third, and fourth reference highlights. Select the second, and only the second highlights. The correct behavior is that selecting any method reference should select all other references. This is the behavior that you see when all are inside the same file. |
Kris De Volder
made changes -
| Attachment | GECLIPSE_1255_more_fun.patch [ 57703 ] |
Kris De Volder
made changes -
| Patch Submitted | [Yes] |
Andrew Eisenberg
made changes -
| Link | This issue is related to GRECLIPSE-1256 [ GRECLIPSE-1256 ] |
Andrew Eisenberg
made changes -
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Assignee | Andrew Eisenberg [ werdna ] | |
| Resolution | Fixed [ 1 ] |
Andrew Eisenberg
made changes -
| Fix Version/s | 2.6.1.M1 [ 18289 ] | |
| Fix Version/s | 2.6.0.Release [ 17849 ] |
This is a patch I received from one of last nights hackathon participants.
It solves the highlighting issue by ignoring parameters in the case where the references is a 'JDTMethodNode'.