GRECLIPSE
  1. GRECLIPSE
  2. GRECLIPSE-124

Slashy string '/' breaks color coding

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.6
    • Fix Version/s: 2.0.2Release
    • Component/s: Inferencing Engine
    • Labels:
      None
    • Environment:
      Eclipse 3.3.2 on Windows Xp pro SP2
    • Number of attachments :
      1

      Description

      I could not find this reported elsewhere. Here is a regex:

      String regExSqlCreate = /create table [a-z".]*($

      {table}[\r\n\d\w\s_,();]+)revoke all on [a-z\".]*${table}

      from "public"/

      As the attached picture shows 'create table [a-z' shows in black, and 'public' shows in keyword color.

        Issue Links

          Activity

          James E. Ervin made changes -
          Field Original Value New Value
          Assignee Edward Povazan [ emp ] Thorsten Kamann [ thorque ]
          Andrew Eisenberg made changes -
          Assignee Thorsten Kamann [ thorque ] Andrew Eisenberg [ werdna ]
          Andrew Eisenberg made changes -
          Link This issue is duplicated by GRECLIPSE-251 [ GRECLIPSE-251 ]
          Andrew Eisenberg made changes -
          Link This issue is duplicated by GRECLIPSE-248 [ GRECLIPSE-248 ]
          Andrew Eisenberg made changes -
          Assignee Andrew Eisenberg [ werdna ]
          Andrew Eisenberg made changes -
          Original Estimate 0 minutes [ 0 ]
          Remaining Estimate 0 minutes [ 0 ]
          Assignee Andrew Eisenberg [ werdna ]
          Andrew Eisenberg made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Andrew Eisenberg added a comment -

          Fixed now. In the latest dev build, slashy strings are no longer handled by the GroovyTagScanner, but rather by the semantic highlighter. This means that we look at the AST to figure out where the slashy strings are; we don't use a scanner. And as long as the file is parseable, we can be certain that we are only highlighting the correct parts of the text. Unfortunately, if the text is not parseable, then we don't highlight anything. I think this is a reasonable limitation.

          Show
          Andrew Eisenberg added a comment - Fixed now. In the latest dev build, slashy strings are no longer handled by the GroovyTagScanner, but rather by the semantic highlighter. This means that we look at the AST to figure out where the slashy strings are; we don't use a scanner. And as long as the file is parseable, we can be certain that we are only highlighting the correct parts of the text. Unfortunately, if the text is not parseable, then we don't highlight anything. I think this is a reasonable limitation.
          Andrew Eisenberg made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Andrew Eisenberg made changes -
          Fix Version/s 2.0.2Release [ 16150 ]
          Andrew Eisenberg made changes -
          Component/s Inferencing Engine [ 14687 ]
          Component/s Code Browsing [ 13143 ]

            People

            • Assignee:
              Andrew Eisenberg
              Reporter:
              tom corcoran
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: