Annotations on import statements are removed after organize imports is called

Actually, the error might not be so important since I put the annotation in an invalid position. If I put it on a class after my imports everything works properly!

This works:

import static groovyx.net.http.ContentType.*
import static groovyx.net.http.Method.*

import java.security.*
import java.security.interfaces.*

import javax.crypto.Cipher
import javax.xml.bind.DatatypeConverter

import groovyx.net.http.*
@Grab(group='org.codehaus.groovy.modules.http-builder', module='http-builder', version='0.5.1' )
public class sh{}

println "doh"

Whereas this doesn't:

@Grab(group='org.codehaus.groovy.modules.http-builder', module='http-builder', version='0.5.1' )
import static groovyx.net.http.ContentType.*
import static groovyx.net.http.Method.*

import java.security.*
import java.security.interfaces.*

import javax.crypto.Cipher
import javax.xml.bind.DatatypeConverter

import groovyx.net.http.*
public class sh{}

println "doh"

The NPE that you see has been fixed with GRECLIPSE-1217. But, there is a new issue that you have uncovered. It looks like annotations are removed from import statements after an organize imports. I have changed the title to reflect the new problem.

Just to be sure...after placing the annotation on the class declaration, you are no longer having any problems?

Yes, that is what I am seeing.

Fixed two related problems here:

• No hovers or navigation for annotations on imports
• No find occurrences either

Both were easy fixes. Unfortunately, fixing organize imports is not simple. We have inherited most of the organize imports code from JDT. The JDT behavior is to strip everything except for the type name from imports after organizing.

Actually...ha! This did turn out to be easy. It turns out that there are different ways of configuring the ImportRewriter. One way keeps old imports and another way removes them. For organize imports, JDT configures it the second way as does Groovy-Eclipse. But, if Groovy-Eclipse changes to the first way, then nothing appears to break and comments are kept as expected.

All tests are still passing and I created a few regression tests for the new functionality (including the other fixes mentioned in my previous comment).

committed the fix.