GRECLIPSE

Code completion throws exception

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.5.1Release
  • Fix Version/s: 2.5.2.Release
  • Component/s: Content Assist
  • Labels:
    None
  • Environment:
    Windows XP, STS 2.7.1
  • Number of attachments :
    1

Description

I'm using SpringSource Tool Suite 2.7.1 and just got the automated upgrade of Groovy-Eclipse to release 2.5.2.xx-20110808-1500-e37. Since I got the upgraded, I've started experiencing the below error from Code Completion.

Steps to reproduce:

  1. Open a Groovy class (either newly created, or an existing class.)
  2. Create an class variable and attempt to use Code Completion on the right side of the assignment, e.g.: 
    class MyClass {
    def something = Class
}

    Then select "Class" and press ctrl-space OR type "." after Class

  3. STS will give a pop-up error message saying "The 'Groovy Code Completions' proposal computer from the 'org.codehaus.groovy.eclipse.codeassist.completion' plug-in did not complete normally. The extension has thrown a runtime exception."

I've found that this occurs whether the declared variable is static or not, whether it is declared with a class name or with "def" and whether the code completion is attempted statically for a class (as in my example) or on another class variable.

I'm attaching the error info, as well as my STS installation details in case that's useful.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Cary Maister added a comment -

Error info:
eclipse.buildId=2.7.1.201107091000-RELEASE
java.version=1.6.0_17
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_US
Framework arguments: -product com.springsource.sts.ide
Command-line arguments: -os win32 -ws win32 -arch x86 -product com.springsource.sts.ide

Warning
Wed Aug 10 12:56:17 EDT 2011
The 'Groovy Code Completions' proposal computer from the 'org.codehaus.groovy.eclipse.codeassist.completion' plug-in did not complete normally. The extension has thrown a runtime exception.

java.util.EmptyStackException
	at java.util.Stack.peek(Stack.java:85)
	at org.codehaus.groovy.eclipse.codeassist.requestor.CompletionNodeFinder.visitClassExpression(CompletionNodeFinder.java:445)
	at org.codehaus.groovy.ast.expr.ClassExpression.visit(ClassExpression.java:35)
	at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitProperty(ClassCodeVisitorSupport.java:142)
	at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1145)
	at org.codehaus.groovy.eclipse.codeassist.requestor.CompletionNodeFinder.visitClass(CompletionNodeFinder.java:198)
	at org.codehaus.groovy.eclipse.codeassist.requestor.CompletionNodeFinder.internalVisitModuleNode(CompletionNodeFinder.java:127)
	at org.codehaus.groovy.eclipse.codeassist.requestor.CompletionNodeFinder.findContentAssistContext(CompletionNodeFinder.java:112)
	at org.codehaus.groovy.eclipse.codeassist.requestor.GroovyCompletionProposalComputer.createContentAssistContext(GroovyCompletionProposalComputer.java:196)
	at org.codehaus.groovy.eclipse.codeassist.requestor.GroovyCompletionProposalComputer.internalComputeCompletionProposals(GroovyCompletionProposalComputer.java:143)
	at org.codehaus.groovy.eclipse.codeassist.requestor.GroovyCompletionProposalComputer.computeCompletionProposals(GroovyCompletionProposalComputer.java:108)
	at org.eclipse.jdt.internal.ui.text.java.CompletionProposalComputerDescriptor.computeCompletionProposals(CompletionProposalComputerDescriptor.java:318)
	at org.eclipse.jdt.internal.ui.text.java.CompletionProposalCategory.computeCompletionProposals(CompletionProposalCategory.java:267)
	at org.eclipse.jdt.internal.ui.text.java.ContentAssistProcessor.collectProposals(ContentAssistProcessor.java:283)
	at org.eclipse.jdt.internal.ui.text.java.ContentAssistProcessor.computeCompletionProposals(ContentAssistProcessor.java:243)
	at org.eclipse.jface.text.contentassist.ContentAssistant.computeCompletionProposals(ContentAssistant.java:1830)
	at org.eclipse.jface.text.contentassist.CompletionProposalPopup.computeProposals(CompletionProposalPopup.java:556)
	at org.eclipse.jface.text.contentassist.CompletionProposalPopup.access$16(CompletionProposalPopup.java:553)
	at org.eclipse.jface.text.contentassist.CompletionProposalPopup$2.run(CompletionProposalPopup.java:488)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.jface.text.contentassist.CompletionProposalPopup.showProposals(CompletionProposalPopup.java:482)
	at org.eclipse.jface.text.contentassist.ContentAssistant$2.run(ContentAssistant.java:377)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4140)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3757)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
Show
Cary Maister added a comment - Error info: eclipse.buildId=2.7.1.201107091000-RELEASE java.version=1.6.0_17 java.vendor=Sun Microsystems Inc. BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_US Framework arguments: -product com.springsource.sts.ide Command-line arguments: -os win32 -ws win32 -arch x86 -product com.springsource.sts.ide Warning Wed Aug 10 12:56:17 EDT 2011 The 'Groovy Code Completions' proposal computer from the 'org.codehaus.groovy.eclipse.codeassist.completion' plug-in did not complete normally. The extension has thrown a runtime exception. java.util.EmptyStackException at java.util.Stack.peek(Stack.java:85) at org.codehaus.groovy.eclipse.codeassist.requestor.CompletionNodeFinder.visitClassExpression(CompletionNodeFinder.java:445) at org.codehaus.groovy.ast.expr.ClassExpression.visit(ClassExpression.java:35) at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitProperty(ClassCodeVisitorSupport.java:142) at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1145) at org.codehaus.groovy.eclipse.codeassist.requestor.CompletionNodeFinder.visitClass(CompletionNodeFinder.java:198) at org.codehaus.groovy.eclipse.codeassist.requestor.CompletionNodeFinder.internalVisitModuleNode(CompletionNodeFinder.java:127) at org.codehaus.groovy.eclipse.codeassist.requestor.CompletionNodeFinder.findContentAssistContext(CompletionNodeFinder.java:112) at org.codehaus.groovy.eclipse.codeassist.requestor.GroovyCompletionProposalComputer.createContentAssistContext(GroovyCompletionProposalComputer.java:196) at org.codehaus.groovy.eclipse.codeassist.requestor.GroovyCompletionProposalComputer.internalComputeCompletionProposals(GroovyCompletionProposalComputer.java:143) at org.codehaus.groovy.eclipse.codeassist.requestor.GroovyCompletionProposalComputer.computeCompletionProposals(GroovyCompletionProposalComputer.java:108) at org.eclipse.jdt.internal.ui.text.java.CompletionProposalComputerDescriptor.computeCompletionProposals(CompletionProposalComputerDescriptor.java:318) at org.eclipse.jdt.internal.ui.text.java.CompletionProposalCategory.computeCompletionProposals(CompletionProposalCategory.java:267) at org.eclipse.jdt.internal.ui.text.java.ContentAssistProcessor.collectProposals(ContentAssistProcessor.java:283) at org.eclipse.jdt.internal.ui.text.java.ContentAssistProcessor.computeCompletionProposals(ContentAssistProcessor.java:243) at org.eclipse.jface.text.contentassist.ContentAssistant.computeCompletionProposals(ContentAssistant.java:1830) at org.eclipse.jface.text.contentassist.CompletionProposalPopup.computeProposals(CompletionProposalPopup.java:556) at org.eclipse.jface.text.contentassist.CompletionProposalPopup.access$16(CompletionProposalPopup.java:553) at org.eclipse.jface.text.contentassist.CompletionProposalPopup$2.run(CompletionProposalPopup.java:488) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70) at org.eclipse.jface.text.contentassist.CompletionProposalPopup.showProposals(CompletionProposalPopup.java:482) at org.eclipse.jface.text.contentassist.ContentAssistant$2.run(ContentAssistant.java:377) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135) at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4140) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3757) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494) at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577) at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
Hide
Permalink
Cary Maister added a comment -

Just noticed: The version for this should be 2.5.2Release

Show
Cary Maister added a comment - Just noticed: The version for this should be 2.5.2Release
Hide
Permalink
Andrew Eisenberg added a comment -

I initially got tripped up because of the capital 'C' in 'Class', but after making it lower case, I can see the problem. This is a bug.

Show
Andrew Eisenberg added a comment - I initially got tripped up because of the capital 'C' in 'Class', but after making it lower case, I can see the problem. This is a bug.
Hide
Permalink
Cary Maister added a comment -

just curious, shouldn't it be a bug for Class with a capital C, too? In that case I'd expect code completion to supply the valid static fields/methods from the Class class? (I guess "Class" was a confusing choice for my example)

Show
Cary Maister added a comment - just curious, shouldn't it be a bug for Class with a capital C, too? In that case I'd expect code completion to supply the valid static fields/methods from the Class class? (I guess "Class" was a confusing choice for my example)
Hide
Permalink
Andrew Eisenberg added a comment -

Class with a 'C' for the class declaration will cause a syntax error in the file and the file will not be able to be properly parsed. So, you will not get any content assist proposals, but there will be no exception thrown either.

Show
Andrew Eisenberg added a comment - Class with a 'C' for the class declaration will cause a syntax error in the file and the file will not be able to be properly parsed. So, you will not get any content assist proposals, but there will be no exception thrown either.
Hide
Permalink
Andrew Eisenberg added a comment -

Fixed with regression test. Will be available in next snapshot build.

Show
Andrew Eisenberg added a comment - Fixed with regression test. Will be available in next snapshot build.

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Cary Maister
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: