If a field has an initializer with a known static type, should use that type as the field's type

I have something working locally that appears to be a good fix. I need to write up some more tests before I can close this issue.

Unfortunately, this fix only works when referring to a field defined in the current file. When referring to an external field, the initializer is not available, so this mechanism will not work directly.

We are considering altering the schema of external ClassNodes so that they will contain field initializers (when they are constants) just so we can get this working.

I accepted a patch from Andy Clement (up until recently, the SVN repo was closed for commits). It does make the initializer available in the field, but there is another problem that this uncovered.

When the field is a property (ie- it has no modifiers), then the field is created twice: once during the parse, and then once again because of the property. This is wrong. It looks like JDTClassNode.createPropertyNodeForMethodNode is being called on the getter method for that field and accidentally creating a second field with the same name.

I think I know how to fix now.

Fix appears to be working. Now, the JDTClassNode.createPropertyNodeForMethodNode method tries to use an existing field, and if it can't find any, then it creates one.

I will write up some tests for this.

The only problem that I can think of is that what if the field is actually declared in a super class? Not sure if this is a problem we need to deal with.

The new tests are passing fine.

It looks like if the field is declared in a super type, then the property is added to the super type (ie- there is no problem with the scenario described in the previous question).

Code is committed with regression tests.