GRECLIPSE

In correct Open Declaration target on overloaded methods with typed arguments

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.5.2.Release
  • Fix Version/s: None
  • Component/s: Content Assist
  • Labels:
  • Number of attachments :
    0

Description

Ctrl+Click ing on f(1,2) will incorrectly navigate to f(List a, List b)

f(1,2)

static f(List a, List b) {}
static f(int a, int b) {}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Eisenberg added a comment -

We don't perform type inferencing of arguments to method calls, all we do is look at numbers of arguments. So this will navigate to the expected declaration:

f(1,2)

static f(List a) {}
static f(int a, int b) {}

Since groovy does dynamic dispatch, this is a very, very difficult task to perform correctly. See GRECLIPSE-729 for more information.

Show
Andrew Eisenberg added a comment - We don't perform type inferencing of arguments to method calls, all we do is look at numbers of arguments. So this will navigate to the expected declaration: f(1,2) static f(List a) {} static f( int a, int b) {} Since groovy does dynamic dispatch, this is a very, very difficult task to perform correctly. See GRECLIPSE-729 for more information.
Hide
Permalink
Bob Tiernay added a comment -

But shouldn't the editor at least try to find the closest match if static types exist and default to the first method if it cannot find a match? I would also assume that there are cases where type inferencing could be inaccurate but that doesn't mean there isn't value in trying.

Show
Bob Tiernay added a comment - But shouldn't the editor at least try to find the closest match if static types exist and default to the first method if it cannot find a match? I would also assume that there are cases where type inferencing could be inaccurate but that doesn't mean there isn't value in trying.
Hide
Permalink
Andrew Eisenberg added a comment -

We definitely could do better in this area.

Show
Andrew Eisenberg added a comment - We definitely could do better in this area.

People

  • Assignee:
    Unassigned
    Reporter:
    Bob Tiernay
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: