GRECLIPSE

Code completion don't work properly with "Completion overwrites"

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1.2Release
  • Fix Version/s: 2.5.0Release
  • Component/s: Content Assist
  • Labels:
    None
  • Environment:
    eclipse helios
    in java preferences -> Editor -> Content Assist -> completion overwrites
  • Number of attachments :
    0

Description

define a variable: def archive = new File(...)
on a new line, type the begining of the variable: arc
ctrl-space and choose the variable "archive" in the lits -> the results will be "archivearc"

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Eisenberg added a comment - - edited

This is not something that we have implemented yet. We should be able to fix this for 2.1.3.

As near as I can tell, this setting is simply ignored when in a Groovy editor.

Show
Andrew Eisenberg added a comment - - edited This is not something that we have implemented yet. We should be able to fix this for 2.1.3. As near as I can tell, this setting is simply ignored when in a Groovy editor.
Hide
Permalink
Andrew Eisenberg added a comment -

The preference constant that controls this setting is:

org.eclipse.jdt.ui.PreferenceConstants.CODEASSIST_INSERT_COMPLETION

value:

content_assist_insert_completion
Show
Andrew Eisenberg added a comment - The preference constant that controls this setting is: org.eclipse.jdt.ui.PreferenceConstants.CODEASSIST_INSERT_COMPLETION value: content_assist_insert_completion
Hide
Permalink
Andrew Eisenberg added a comment -

I have a solution that is working for field and method completion. It is not yet working for type and constructor completions.

This problem has uncovered a few other inconsistencies with calculating locations for completion. I will fix those as well.

Show
Andrew Eisenberg added a comment - I have a solution that is working for field and method completion. It is not yet working for type and constructor completions. This problem has uncovered a few other inconsistencies with calculating locations for completion. I will fix those as well.
Hide
Permalink
Andrew Eisenberg added a comment - - edited

Complete fix is now committed.

The problem was that the replaceLength was not being computed properly. When completions are in 'insert' mode, the replaceLength is not used, but instead only the replaceStart and actualInsertion point are used. However, when switching to 'overwrite' mode, replaceLength is used. Since we have never tested with this setting enabled, we never encountered the problem.

actualInsertion: the caret location
replaceStart: the starting offset of the insertion token
replaceLength: the total length of the insertion token

Show
Andrew Eisenberg added a comment - - edited Complete fix is now committed. The problem was that the replaceLength was not being computed properly. When completions are in 'insert' mode, the replaceLength is not used, but instead only the replaceStart and actualInsertion point are used. However, when switching to 'overwrite' mode, replaceLength is used. Since we have never tested with this setting enabled, we never encountered the problem. actualInsertion: the caret location replaceStart: the starting offset of the insertion token replaceLength: the total length of the insertion token
Hide
Permalink
Christophe Domas added a comment -

Thanks a lot.

Show
Christophe Domas added a comment - Thanks a lot.

People

  • Assignee:
    Andrew Eisenberg
    Reporter:
    Christophe Domas
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: