Issue Details (XML | Word | Printable)

Key: GRAILSPLUGINS-319
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: T.Yamamoto
Reporter: Burt Beckwith
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Grails Plugins

bugs in Acegi plugin session handling

Created: 08/Apr/08 08:48 AM   Updated: 30/Sep/08 11:29 PM
Component/s: None
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments: 1. Zip Archive fixed.zip (4 kB)


Patch Submitted: Yes


 Description  « Hide
There are two bugs in the Hibernate session handling code:
  • GrailsDaoImpl is a singleton bean but keeps the session and the boolean indicating if the session was pre-existing as class-scope fields. So users have seen that it's possible for a 2nd thread to overwrite and close the session before the 1st thread is finished
  • although GrailsDaoImpl puts its session-related code in a try/finally, GrailsFilterInvocationDefinition does not, so it's possible to leak connections

I've fixed this in the version of the plugin that I sent to you but to help out the users who are affected by these bugs I posted fixed versions to the mailing list and am attaching them here until the plugin is updated.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
T.Yamamoto added a comment - 14/Apr/08 05:37 AM
Thank you for fix code.

Animesh Jain added a comment - 06/Jul/08 09:35 AM
has the patch been included in the latest release - 1.0.3 ?

Burt Beckwith added a comment - 07/Jul/08 06:19 AM
Yes, this was in the 0.2.1 and 0.3 releases.