[#GRAILS-989] GSP File locks? - jira.codehaus.org

Grails

GSP File locks?

Created: 28/Mar/07 03:43 AM Updated: 20/Apr/07 03:30 AM

Component/s:

View technologies

Affects Version/s:

0.5-RC1

Fix Version/s:

0.5-RC1

Time Tracking:

Not Specified

Environment:

Java 5, Windows XP

Description

« Hide

User list thread: http://www.nabble.com/GSP-file-locks--%28Windows-of-course%29-tf3474519.html

Basically the issue appears to be that GSP file handles are not released, though I haven't done any investigation.

To reproduce it you may have to use JEdit because it seems to be the only editor I use to be affected by this. Typically i can modify the file a few times then on all subsequent attempts I get the error.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Maurice Nicholson - 30/Mar/07 04:10 AM

We also noticed today that this effectively prevents updating a running application's GSPs from SVN (using Eclipse)!

It seems to be doing something similar to JEdit with temporary ".tmp" files which I assume it then renames to the target file and fails in the same way as JEdit.

[ Permlink | « Hide ]

Graeme Rocher - 10/Apr/07 06:17 AM

I believe this is fixed, please update and test and close issue if you are satisfied it is

[ Permlink | « Hide ]

Maurice Nicholson - 11/Apr/07 06:23 AM

I tested with the latest code - in particular your changes to GroovyPagesTemplateEngine.java - but it's not fixed. I get the same issue with JEdit. Sorry

[ Permlink | « Hide ]

Michael Baehr - 13/Apr/07 03:30 PM

I start an application with grails run-app, then modify a controller in
JEdit and reload a page using that controller several times.

After a couple of tries, JEdit cannot save anymore. Using a tool to
check file handles, I see that grails has file locks on MANY files, like
all the Taglibs, all the Datasources (yes, not just TestDataSource),
message files, GSPs and so on. I'm not 100% sure but it almost looks like all
files in my application get locked!

These locks get removed minutes later - maybe session invalidation?

[ Permlink | « Hide ]

Graeme Rocher - 16/Apr/07 06:22 PM

What tool did you use to check the file handles?

[ Permlink | « Hide ]

Graeme Rocher - 20/Apr/07 03:30 AM

I believe the problem was in the GCL itself, I committed an updated GCL into Grails and have tested it on windows and was not able to replicate the problem even after changing a view like 20 times