Issue Details (XML | Word | Printable)

Key: GRAILS-3467
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Graeme Rocher
Reporter: Robert Fischer (Smokejumper Consulting)
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Grails

Change "Events.groovy" to be "_Events.groovy"

Created: 12/Oct/08 12:35 PM   Updated: 02/Dec/08 01:35 AM
Component/s: None
Affects Version/s: 1.0.4
Fix Version/s: 1.0.4

Time Tracking:
Not Specified

File Attachments: 1. File patch.diff (1 kB)


Patch Submitted: Yes


 Description  « Hide
If the script file is "Events.groovy", you end up getting an "events" command-line task. This probably isn't intentional, so we should instead use "_Events.groovy" as the file name.

Attached is a patch which will try to use "_Events.groovy", and if it doesn't exist, will use "Events.groovy" and display a warning message to the screen. My suggestion would be to use this, and in 1.1, do away with "Events.groovy" in favor of "_Events.groovy" altogether.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Graeme Rocher added a comment - 10/Nov/08 10:00 AM
Since this is a breaking change we'll put it into 1.1

Robert Fischer (Smokejumper Consulting) added a comment - 10/Nov/08 10:05 AM
For the record, the patch I submitted allows you to use either "Events.groovy" or "_Events.groovy", explicitly so that it won't be a breaking change.

You've got bigger fish to fry, though, so postponing this to a 1.1 release in order to get 1.0.4 out sooner is OK by me.


Graeme Rocher added a comment - 10/Nov/08 01:36 PM
Oh ok, wasn't aware of that so moving back

Robert Fischer (Smokejumper Consulting) added a comment - 10/Nov/08 01:41 PM
Yeah, I was pretty sneaky and subtle with how I mentioned the transitional nature of the patch right there in the issue description. ;-D

Graeme Rocher added a comment - 12/Nov/08 04:33 AM
Thanks for the patch!

Peter Ledbrook added a comment - 02/Dec/08 01:35 AM
Due to the script refactoring, this got lost in the merge, sorry. It will be there for beta2.