| Field |
Original Value |
New Value |
|
Description
|
The attached patch brings the test coverage to 100% for GroovyIfTag#doStartTag. The additional tests in the patch address the two cases [not covered|http://build.canoo.com/grails/artifacts/coverage/org.codehaus.groovy.grails.web.taglib.GroovyIfTag.html] in the current tests.
The patch also offers refactorings for the #doStartTag implementation. These refactorings use method extraction to reduce repetition. They also cut the amount of conditional logic in half.
|
The attached patch brings the test coverage to 100% for GroovyIfTag#doStartTag. The additional tests in the patch address the two cases [not covered|http://build.canoo.com/grails/artifacts/coverage/org.codehaus.groovy.grails.web.taglib.GroovyIfTag.html] in the current tests.
The patch also offers refactorings for the #doStartTag implementation. These refactorings use method extraction to reduce repetition. They also cut the amount of conditional logic in half.
--
Note: The test improvements (in CoreTagsTests.groovy) are independent of the refactorings (in GroovyIfTag.java). In case the team disagrees with the refactorings, the additional test cases can still be applied to offer increased test coverage for the existing code base.
|
Added note about the test improvements being independent of the refactorings.