|
[
Permalink
| « Hide
]
Jason Rudolph added a comment - 16/Feb/08 02:55 PM
Corrected link to current coverage report for WebUtils.java.
Should we not rename the tests so that they match the convention? Also, I would consider removing ManyToManyTest since the useful code appears to be commented out. In general though, I think the rename is a good idea. BTW, SampleUnitOneToMany.groovy should be SampleUniOneToMany.groovy.
Hi Peter,
I agree that the tests should follow a consistent naming convention. I'd consider that to be a superior enhancement. If the team agrees, I'm happy to submit a patch that makes that change instead of updating ant/build/unit-test.xml. Cheers, Agreed this would be a better patch
In the meantime i've renamed WebUtilsTest (ie added the s)
Thanks, Graeme. I'll put together an updated patch and post it here.
The updated patch renames the remaining test classes ending in "Test" to instead end in "Tests", thus making all Grails test classes follow a consistent naming convention.
test/persistence/org/codehaus/groovy/grails/orm/hibernate/cfg/GrailsDomainConfigurationUtilTest.java The patch no longer modifies the build script (as the renaming process above removes the need to change the build script). |
|||||||||||||||||||||||||||||||||||||||||||||||||||