I was trying to create a filter that would be called in the 'before' and 'afterView' stages of processing and I think I may have found a bug. Basically I wasn't seeing my 'afterView' filter getting called. The filter looks basically like this:
class MyFilters {
def filters = {
contextSetup(controller: '*', action: '*') {
before = {
if (Context.getContext() == null) {
Context.createContext(request, response)
}
}
afterView = {
if (Context.getContext() != null) {
Context.destroyContext ()
}
}
}
}
}
Where Context is my own app specific Java class. I dug into this a bit and found that in the Grails class:
org.codehaus.groovy.grails.plugins.web.filters.FilterToHandlerAdapter , the afterCompletion methos looks like this:
void afterCompletion(HttpServletRequest request, HttpServletResponse response, Object o, Exception e) throws java.lang.Exception {
if (filterConfig.afterComplete ) {
String controllerName = controllerName(request)
String actionName = actionName(request)
String uri = uri(request)
if (!accept(controllerName, actionName, uri)) return;
def callable = filterConfig.afterView.clone()
callable.delegate = new FilterActionDelegate()
callable.resolveStrategy = Closure.DELEGATE_FIRST
callable.call (e);
}
}
I believe the line:
if (filterConfig.afterComplete) {
should read:
if (filterConfig.afterView) {
Description
I was trying to create a filter that would be called in the 'before' and 'afterView' stages of processing and I think I may have found a bug. Basically I wasn't seeing my 'afterView' filter getting called. The filter looks basically like this:
class MyFilters {
def filters = {
contextSetup(controller: '*', action: '*') {
before = {
if (Context.getContext() == null) {
Context.createContext(request, response)
}
}
afterView = {
if (Context.getContext() != null) {
Context.destroyContext ()
}
}
}
}
}
Where Context is my own app specific Java class. I dug into this a bit and found that in the Grails class:
org.codehaus.groovy.grails.plugins.web.filters.FilterToHandlerAdapter , the afterCompletion methos looks like this:
void afterCompletion(HttpServletRequest request, HttpServletResponse response, Object o, Exception e) throws java.lang.Exception {
if (filterConfig.afterComplete ) {
String controllerName = controllerName(request)
String actionName = actionName(request)
String uri = uri(request)
if (!accept(controllerName, actionName, uri)) return;
def callable = filterConfig.afterView.clone()
callable.delegate = new FilterActionDelegate()
callable.resolveStrategy = Closure.DELEGATE_FIRST
callable.call (e);
}
}
I believe the line:
if (filterConfig.afterComplete) {
should read:
if (filterConfig.afterView) {
Bug
Resolved
Blocker
Filter 'afterView' closure not called properly