[#GRAILS-1019] g:select should take a disbaled="${expr}" to allow dynamic disabling based on model state

Grails

g:select should take a disbaled="${expr}" to allow dynamic disabling based on model state

Created: 03/Apr/07 11:56 AM Updated: 06/Jun/08 03:23 PM

Component/s:

TagLib

Affects Version/s:

0.5-RC1

Fix Version/s:

1.0.4

Time Tracking:

Not Specified

File Attachments:

FormTagLib.2.patch (0.9 kB)
2.

FormTagLib.patch (0.9 kB)

Description

« Hide

It would be nice if the <g:select /> tag took a "disabled" attribute which in turn took an expression, eg:

<g:select disabled="${canChoose}" .../>

Currently if you try this you get

<select disabled="true" .../> <!-- or -->
    <select disabled="false" .../>

which in IE and FF disables the select either way.

Here's an example implementation that does the trick, which also supports literal strings, eg, <g:select disabled="disabled" .../>

def disabled = attrs.remove("disabled")
        if (!disabled.equals(false)) {
            attrs.disabled = "disabled"
        }

The key is to only output the disabled attribute when it should be disabled - the actual value is irrelevant.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Maurice Nicholson added a comment - 12/Apr/07 10:05 AM

Actually the above doesn't work when a disabled property is NOT provided.

Here is a simplification that works with or without a disabled property:

def disabled = attrs.remove("disabled")
        if (disabled) {
            attrs.disabled = "disabled"
        }

[ Permlink | « Hide ]

Mingfai Ma added a comment - 14/Apr/08 08:25 AM

I got exactly the same problem. And I have patched the FormTagLib and tested it.

It's actually a deflect in HTML as in HTML, no matter disabled="true" or disabled="false", the select box is disabled. Maurice and I's patch basically make the disabled attribute be write only if the value is true.

Reference:
http://www.w3schools.com/tags/tag_select.asp

[ Permlink | « Hide ]

Mingfai Ma added a comment - 14/Apr/08 08:31 AM

A small change is made to write
disabled = "disabled"
rather than just
disabled

The updated version is a more standard-based way to write HTML

[ Permlink | « Hide ]

Mingfai Ma added a comment - 06/Jun/08 11:18 AM

This fix is not included in 1.0.3. I suppose we have a good solution and the fix is very simple. could it be included in the next release?

[ Permlink | « Hide ]

Matthew Taylor added a comment - 06/Jun/08 03:23 PM

Expressions that resolve to a boolean value can now be used for the disabled attrib for g:select, g:radio, and g:checkBox. String values can also be used (true,false,yes,no).