[#GRAILS-1016] Change UrlMappings to be a class, and don't use <applicationName>UrlMappings as name

Grails

Change UrlMappings to be a class, and don't use <applicationName>UrlMappings as name

Created: 03/Apr/07 07:21 AM Updated: 20/Apr/07 07:40 AM

Component/s:

None

Affects Version/s:

0.5-RC1

Fix Version/s:

0.5-RC1

Time Tracking:

Not Specified

File Attachments:

src-commons.patch (4 kb)
2.

src-web.patch (13 kb)
3.

test-web.patch (4 kb)

Description

« Hide

Why is MyProjectUrlMappings.groovy the filename, instead of just UrlMappings.groovy like ApplicationBootStrap.groovy for example, or ApplicationUrlMappings.groovy?

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Alex Shneyderman - 03/Apr/07 12:05 PM

I do not think the name neccessarily has to be that way. simply UrlMapping.groovy works for me.

[ Permlink | « Hide ]

Alex Shneyderman - 13/Apr/07 02:49 AM

src/commons module's patch.

[ Permlink | « Hide ]

Alex Shneyderman - 13/Apr/07 02:50 AM

src/web modules' patch

[ Permlink | « Hide ]

Alex Shneyderman - 13/Apr/07 02:50 AM

test/web module's patch

[ Permlink | « Hide ]

Alex Shneyderman - 13/Apr/07 02:53 AM

At the moment the mappings closure needs to be static. That's because of ~~GROOVY-1829~~ issue. Jochen claims to fix it, but untill we update groovy-all to incorporate that file this patches will work with static mappings closure only. Once the patched version of groovy is brought over it should work both ways.

[ Permlink | « Hide ]

Graeme Rocher - 13/Apr/07 03:28 AM

Btw I still think the file needs to be MyProjectUrlMappings.groovy because what if a plug-in provides some URL mappings. then you have two classes with the name UrlMappings.groovy which will cause an error.

[ Permlink | « Hide ]

Graeme Rocher - 20/Apr/07 07:40 AM

Thanks Alex for your hard work on this patch, much appreciated!