Groovy Modules

FileNotFoundException (really IOExceptions in general) swallowed by XMLRPCServerProxy

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: XML-RPC
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

The XMLRPCServerProxy class swallows IOExceptions in the invokeMethod method by throwing an XMLRPCCallFailureException (which by design have no caused by Throwable). This prevents users from being able to distinguish between generic IOExceptions and, for example, FileNotFoundExceptions.
The submitted patch fixes this by permitting XMLRPCCallFailureExceptions to have caused by Throwables/Exceptions and using this new Constructor in the invokeMethod method of XMLRPCServerProxy.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guillaume Laforge added a comment -

John, I'd like your advice on this.

Show
Guillaume Laforge added a comment - John, I'd like your advice on this.
Hide
Permalink
John Wilson added a comment -

The patch looks fine - please apply it.

Show
John Wilson added a comment - The patch looks fine - please apply it.
Hide
Permalink
John Wilson added a comment -

Show
John Wilson added a comment -
Hide
Permalink
Guillaume Laforge added a comment -

Patch applied.
Thanks a lot.

Show
Guillaume Laforge added a comment - Patch applied. Thanks a lot.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.