[#GMOD-168] HttpBuilder POST does not send request content type - jira.codehaus.org

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: HTTPBuilder-0.5.1
Fix Version/s: HTTPBuilder-0.5.2
Component/s: HttpBuilder
Labels:
None

Number of attachments :
0

Description

Whether i pass the content-type to the request method, e.g.
http.request(Method.POST, "text/xml") { req ->
or set it explicitely with
requestContentType = "text/xml"
the POSTed http request will always have content-type "application/xml".

The problem lies in HTTPBuilder.doRequest( final RequestConfigDelegate delegate ): it does not set the request content-type at all (it only sets the accept-content-type). I guess the underlying HttpClient library uses "application/xml" as default when no content type is set.

There is a simple work around: set the content-type header explicitely, as in
headers = [ 'Content-Type': 'text/xml']

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Thom Nichols added a comment - 22/Feb/11 4:53 PM

You're sort of right. The EncoderRegistry class is setting the content-type header. However for content-types that have multiple variants (See ContentType.java,) each encoder function is taking the 'default' representation for that content-type, and not taking into consideration if a more specific content-type string was given.

For example, if you did something like this:

http.request(POST,'text/plain') {
	body = "blah"
	response.success = { resp ->
		System.out << resp.data
	}
}

you'd see:

2011-02-22 17:07:01,010 DEBUG  headers - >> POST / HTTP/1.1
2011-02-22 17:07:01,010 DEBUG  headers - >> Accept: text/plain
2011-02-22 17:07:01,010 DEBUG  headers - >> Content-Type: text/plain
...

That said, it definitely should respect the string content-type you've given. I'll fix this for 0.5.2.

Show

Thom Nichols added a comment - 22/Feb/11 4:53 PM You're sort of right. The EncoderRegistry class is setting the content-type header. However for content-types that have multiple variants (See ContentType.java,) each encoder function is taking the 'default' representation for that content-type, and not taking into consideration if a more specific content-type string was given. For example, if you did something like this: http.request(POST,'text/plain') { body = "blah" response.success = { resp -> System .out << resp.data } } you'd see: 2011-02-22 17:07:01,010 DEBUG headers - >> POST / HTTP/1.1 2011-02-22 17:07:01,010 DEBUG headers - >> Accept: text/plain 2011-02-22 17:07:01,010 DEBUG headers - >> Content-Type: text/plain ... That said, it definitely should respect the string content-type you've given. I'll fix this for 0.5.2.

Hide

Permalink

Thom Nichols added a comment - 12/Mar/11 4:34 PM

Fixed in r916. If contentType is given as a String, always use that string, not the default ContentType enum equivalent.

Show

Thom Nichols added a comment - 12/Mar/11 4:34 PM Fixed in r916. If contentType is given as a String, always use that string, not the default ContentType enum equivalent.

HttpBuilder POST does not send request content type

Details

Description

Activity

People

Dates