Cannot use @Test(expected=...) without .class suffix

It's likely that this is a bug in groovyc's stub generator and not GMaven's fault. To verify, check "IDEA -> Preferences -> Compiler -> Groovy Compiler -> Use groovyc's native stub generator" and see if you get the same error in IDEA. By default, IDEA uses its own stub generator, which is more mature than Groovy's.

Meanwhile, are you sure you need stub generation for your tests (i.e. do you have Java->Groovy dependencies in your tests)?

Hi Peter, thanks for the reply.

I changed the Stub generation in IntelliJ to use the native stub generator, and it compiles without problems, so my guess is that it's still a GMaven thing.

I probably don't need stub generation for my tests, but how can I control that? I just did a mvn clean install, which generates all the stub's for me, even for my tests. Can I turn it off explicitly? However, I don't think that will change anything. If I have a class which looks likes this:

class Person {
   @Mapping(mapping=SomeTypeMapper)
   private Field typeToMap
}

My guess (haven't tested it yet) is that this will also fail in GMaven.

The most bugs I experience with GMaven are related to stub generation (like all imports missing, and currently the issue for BigDecimal).

I don't know if I need joint compilation, but I just don't need it for my tests.

No, I haven't verified that I need it. At the moment, I probably don't, for as far as I know, we only use Groovy code. I'm currently using 1.7.4 in combination with GMaven.

But either I turn it on or off, it's still an issue people could by affected by.

Of course these things should be fixed. I'm just saying that it's always better to turn off joint compilation if you don't need it. This will speed up compilation significantly and save you from a lot of troubles (stub generation bugs, incompatibility with AST transforms, problems with tools and IDEs).
You only need joint compilation if you have Java classes that reference Groovy classes in the same Maven module. As long as you keep dependencies within a module unidirectional (Groovy->Java), you don't need joint compilation.

This is a problem with the Groovy stub-generator. I've just setup a simple test project using groovyc and the stub that gets generated for @Test(expected=IllegalArgumentException) does not get .class appended. The groovyc task seems to be fine to let this slide, perhaps because it knows that its not actually going to compile that stub? Anyways, adding a javac afterwards to ensure that the stubs are compilable shows that they clearly are not.

This is what I am using more or less to drive/test it:

<project default="all">

    <property name="groovy.jar" value="groovy-all-1.7.4.jar"/>

    <target name="all">
        <taskdef name="groovyc" classname="org.codehaus.groovy.ant.Groovyc">
            <classpath>
                <pathelement location="${groovy.jar}"/>
            </classpath>
        </taskdef>

        <delete dir="target"/>
        <mkdir dir="target/classes"/>
        <mkdir dir="target/stubs"/>

        <groovyc srcdir="src" destdir="target/classes" stubdir="target/stubs" keepstubs="true">
            <classpath>
                <pathelement path="target/classes"/>
                <pathelement location="${groovy.jar}"/>
                <fileset dir="lib">
                    <include name="*.jar"/>
                </fileset>
            </classpath>
            <javac source="1.5" target="1.5" debug="on"/>
        </groovyc>

        <mkdir dir="target/stub-classes"/>
        <javac srcdir="target/stubs" destdir="target/stub-classes" source="1.5" target="1.5">
            <classpath>
                <pathelement path="target/classes"/>
                <pathelement location="${groovy.jar}"/>
                <fileset dir="lib">
                    <include name="*.jar"/>
                </fileset>
            </classpath>
        </javac>
    </target>

</project>

I've put this into a project here:

• http://github.com/jdillon/groovy-stub-test

Hi Jason,

What's next? Should I report this bug in the Groovy project?

Erik

Hi Jason,

What's next? Should I report this bug in the Groovy project?

Erik

Yes, please do report a bug. I'm looking into it right now.

Done. See GROOVY-4354

I also just mailed the list with details.