GeoTools

EPSG DefaultFactory does not work in an EJB environment

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.2-RC2
  • Fix Version/s: 2.7.6
  • Component/s: referencing
  • Labels:
    None
  • Environment:
    Windows XP SP2, JDK 1.5.0_06, JBoss 4.0.4-GA

Description

The current implementation of org.geotools.referencing.factory.epsg.DefaultFactory in conjunction with org.geotools.referencing.factory.epsg.DataSource has several issues in JBoss:

  • The DATASOURCE_NAME is hardcoded to a name that is not appropriate for JBoss (it should be 'java:EPSG'). I suggest to make the name configurable, perhaps with a Hint.
  • Extending javax.sql.DataSource prevents the use of a standard J2EE JDBC data source. It is also inappropriate to do this just to create the actual factory.
  • In a multiuser-environment, it is not appropriate to permanently reserve a database connection from a pool like FactoryUsingSQL does it. A connection should just be obtained from the pool when needed and then returned by closing it.
  • The current architecture has problems with concurreny: either one uses just a single factory, then it becomes a bottleneck. Or one uses a pool of factories, but then the connection hogging (see above) becomes a serious issue.

Issue Links

depends upon

Improvement - An improvement or enhancement to an existing feature or task. GEOT-1286 Add Concurrency Support to CRS Authority

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Felix Mayer made changes -
Field Original Value New Value
Description The current implementation of org.geotools.referencing.factory.epsg.DefaultFactory in conjunction with org.geotools.referencing.factory.epsg.DataSource has several issues in JBoss:

- The DATASOURCE_NAME is hardcoded to a name that is not appropriate for JBoss (it should be 'java:EPSG'). I suggest to make the name configurable, perhaps with a Hint.
- Extending javax.sql.DataSource prevents the use of a standard J2EE data source. It is also inappropriate to do this just to create the actual factory.
- In a multiuser-environment, it is not appropriate to permanently reserve a database connection from a pool like FactoryUsingSQL does it. A connection should just be obtained from the pool when needed and then returned by closing it.
- The current architecture has problems with concurreny: either one uses just a single factory, then it becomes a bottleneck. Or one uses a pool of factories, but then the connection hogging (see above) becomes a serious issue. 		The current implementation of org.geotools.referencing.factory.epsg.DefaultFactory in conjunction with org.geotools.referencing.factory.epsg.DataSource has several issues in JBoss:

- The DATASOURCE_NAME is hardcoded to a name that is not appropriate for JBoss (it should be 'java:EPSG'). I suggest to make the name configurable, perhaps with a Hint.
- Extending javax.sql.DataSource prevents the use of a standard J2EE JDBC data source. It is also inappropriate to do this just to create the actual factory.
- In a multiuser-environment, it is not appropriate to permanently reserve a database connection from a pool like FactoryUsingSQL does it. A connection should just be obtained from the pool when needed and then returned by closing it.
- The current architecture has problems with concurreny: either one uses just a single factory, then it becomes a bottleneck. Or one uses a pool of factories, but then the connection hogging (see above) becomes a serious issue.
Martin Desruisseaux made changes -
Remaining Estimate 0 minutes [ 0 ]
Time Spent 3 days [ 259200 ]
Cory Horner made changes -
Link This issue depends upon GEOT-1286 [ GEOT-1286 ]
Jody Garnett made changes -
Assignee Martin Desruisseaux [ desruisseaux ]
Jody Garnett made changes -
Fix Version/s 2.7-M0 [ 15891 ]
Jody Garnett made changes -
Fix Version/s 2.7-M1 [ 16521 ]
Fix Version/s 2.7-M0 [ 15891 ]
Jody Garnett made changes -
Fix Version/s 2.7-RC1 [ 16571 ]
Fix Version/s 2.7-M1 [ 16521 ]
Jody Garnett made changes -
Fix Version/s 2.7-M3 [ 16572 ]
Fix Version/s 2.7-M2 [ 16571 ]
Justin Deoliveira made changes -
Fix Version/s 2.7-M4 [ 16726 ]
Fix Version/s 2.7-M3 [ 16572 ]
Andrea Aime made changes -
Fix Version/s 2.7-beta1 [ 16974 ]
Fix Version/s 2.7-M4 [ 16726 ]
Justin Deoliveira made changes -
Fix Version/s 2.7-RC1 [ 17076 ]
Fix Version/s 2.7-beta1 [ 16974 ]
Justin Deoliveira made changes -
Fix Version/s 2.7.0 [ 17109 ]
Fix Version/s 2.7-RC1 [ 17076 ]
Justin Deoliveira made changes -
Fix Version/s 2.7.1 [ 17255 ]
Fix Version/s 2.7.0 [ 17109 ]
Justin Deoliveira made changes -
Fix Version/s 2.7.2 [ 17359 ]
Fix Version/s 2.7.1 [ 17255 ]
Jody Garnett made changes -
Fix Version/s 2.7.3 [ 17442 ]
Fix Version/s 2.7.2 [ 17359 ]
Andrea Aime made changes -
Fix Version/s 2.7.4 [ 17863 ]
Fix Version/s 2.7.3 [ 17442 ]
Justin Deoliveira made changes -
Fix Version/s 2.7.5 [ 18236 ]
Fix Version/s 2.7.4 [ 17863 ]
Justin Deoliveira made changes -
Fix Version/s 2.7.6 [ 18554 ]
Fix Version/s 2.7.5 [ 18236 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Felix Mayer
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: