jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • GeoTools
  • GEOT-9

SLD Specification Compliance

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-b1
  • Fix Version/s: 2.2-RC2
  • Component/s: main
  • Labels:
    None

Description

While mostly adhering to the structure and semantics of the SLD specification, the API is lacking some key pieces and some naming conventions are broken. Additional, the current XMLEncoder does not produce formatted XML and misses out on encoding certain elements.

Missing Pieces:
1) Lack of representation for StyledLayerDescriptor
The root of an SLD document, this element contains the child elements
sld:NamedLayer and sld:UserLayer in addition to the version
attribute.
2) Lack of representation for NamedLayer which contains the elements
sld:Name, sld:LayerFeatureConstraints, and the choice of
sld:NamedStyle or sld:UserStyle.

Problems:
1) The misnamed SLDStyle object, which is resposible for decoding a
SLD, misses out on the NamedStyle, a key piece of WMS.
2) Creation of an SLD document through the existing XMLEncoder is
limited as a result of these missing elements.

Broken conventions (that I found):
PointSymbolizer geometryPropertyName and setGeometryPropertyName

Problem:
1) By not sticking to JavaBeans naming conventions, the automatic
creation of editors is hindered, the proper use is get/set.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. GEOT-605 SLD Parser incorrectly handles UserLayer elements and subelemets

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. GEOT-784 SLDTransformer cannot handle elements above UserStyle

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • History
  • Activity
Hide
Permalink
Sean Geoghegan added a comment - 17/Oct/03 9:04 PM
I'd like to add that the current method of encoding XML using streaming output is fragile. For example, if I have an SLD object with the &, < or > characters in any of its properties, the output is not going to be valid XML. The Filter XMLEncoder also suffers from the same problem.

The recommended way to solve this is to use a TransformerHandler to which you send sax events, for example:

TransformerHandler th;

th.startElement(SLD_NAMESPACE, "UserStyle", null, attributes);

// do the rest

th.startElement(SLD_NAMESPACE, "UserStyle", null);

This has the advantage that XML special characters are automatically converted and the outptu is formatted for you.
Show
Sean Geoghegan added a comment - 17/Oct/03 9:04 PM I'd like to add that the current method of encoding XML using streaming output is fragile. For example, if I have an SLD object with the &, < or > characters in any of its properties, the output is not going to be valid XML. The Filter XMLEncoder also suffers from the same problem. The recommended way to solve this is to use a TransformerHandler to which you send sax events, for example: TransformerHandler th; th.startElement(SLD_NAMESPACE, "UserStyle", null, attributes); // do the rest th.startElement(SLD_NAMESPACE, "UserStyle", null); This has the advantage that XML special characters are automatically converted and the outptu is formatted for you.
Hide
Permalink
Ian Turton added a comment - 20/Oct/03 4:56 AM
I'll take a look at this but it won't be until next month, so if others
want to start with out me feel free.
Show
Ian Turton added a comment - 20/Oct/03 4:56 AM I'll take a look at this but it won't be until next month, so if others want to start with out me feel free.
Hide
Permalink
Ian Wolfe Schneider added a comment - 20/Oct/03 11:05 AM
In regards to Seans comment on the recommended way to handle SLDEncoding, this is precisely the method I've chosen to handle this.
Show
Ian Wolfe Schneider added a comment - 20/Oct/03 11:05 AM In regards to Seans comment on the recommended way to handle SLDEncoding, this is precisely the method I've chosen to handle this.
Hide
Permalink
Jody Garnett added a comment - 13/Mar/06 1:59 AM
We have performed a check against SLD 1.0 as part of geotools 2.2.x
Show
Jody Garnett added a comment - 13/Mar/06 1:59 AM We have performed a check against SLD 1.0 as part of geotools 2.2.x

People

  • Assignee:
    James Macgill
    Reporter:
    Ian Wolfe Schneider
Vote (0)
Watch (0)

Dates

  • Created:
    17/Oct/03 3:03 PM
    Updated:
    13/Mar/06 1:59 AM
    Resolved:
    13/Mar/06 1:59 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.