Support java.math as Filter Functions

Chris Holmes added a comment - 24/May/06 6:20 PM From email: Hi Chris. I managed to check out geotools with the svn plugin for eclipse, but I was never able to build anything, the mvn install gave me some weired errors which I couldn't figure out, so I ended up just downloading the soruce code and settting up my own geotools project in eclipse.. Anyway I managed to get the MakeFunctionClasses work for java.Math, I have modified it a bit so it also writes a JUnit test to test the functions that it writes. I have attatched two zip files, one with the modified function writer, note that it is not very generic, it works for java.Math to use it on other classes will mean more modifications. The other is the result I get from running the function writer, note that the file FilterFunciton_Test is a JUnit test which tests that the other functions work. I have also attached the new service provider file. In this file I have deleted the MaxFunction and the MinFunction since the FunctionFinder finds them instead the new ones, not that they are better but my JUnit test failed because of it and this was the easy solution, there is probably no need for two Min and Max functions anyway... Note that some of the java.Math functions exist for different input arguments, i.e. Math.abs(double d) and Math.abs(float f), in these cases I have made one FilterFunction for each and just appended _2, _3 or _4 to their names. I think that people should know what type of input they are giving to the function and might also need a specific type of output, if you totally disagree it is very simple to change the FilterFunctions which are affected, but less simple to make the function writer do this. I hope that everything makes sense and that you can use some of the work I have done.. Best Regards............... Kasper Kaergaard

Chris Holmes added a comment - 26/May/06 6:21 PM Ok, applied this. Was kind of a bitch, the original code was against java 1.5. I never managed to get the code generator running, which I propabaly should have just taken the time to do. But it's done now. Had to change things a bit for trunk and the new experession stuff. Also deprecated the older min/max functions, since the new ones are better. Also reordered the min functions, so the parameters taken match up with the max ones. r19684 - r19692