GeoTools

DataStore parser doesnīt allow column with name "name"

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.1.RC0
  • Fix Version/s: 2.7.6
  • Component/s: xml
  • Labels:
    None

Description

My application throws an exception when I use a DataStore connected to a PostGIS
table with a column named "name". I am using Geoserver.
There is a bug that make it impossible to use a table with a column
named "name".

The problem happens only when Geoserver query answers have a column named "name".
Debugging the xml parser code, I have found in
org.geotools.xml.handlers.ComplexElementHandler that the class attribute "type"
contains the name of all table columns and some other objects.
But there are **TWO** instances with a name "name", when the table has such
a column. The second occurrence is related to the desired column, but the
first occurrence is something else. Maybe every type has automatically this
object with name "name", even when there is no column named "name".

The two occurrences of "name" should be treated differently.
I have fixed this bug by searching "type" backwards, from the end to the beginning, in
org.geotools.xml.handlers.xsi.ComplexTypeHandler.DefaultSequence.findChildElement.
But I donīt think it is an elegant solution - I even donīt know it is a solution
for all similar cases

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jody Garnett added a comment -
Apparently still unfixed - please use Fix Version to mark actual fixes.
Show
Jody Garnett added a comment - Apparently still unfixed - please use Fix Version to mark actual fixes.
Jody Garnett made changes -
Field Original Value New Value
Environment
Description My application throws an exception when I use a DataStore connected to a PostGIS
table with a column named "name". I am using Geoserver.
There is a bug that make it impossible to use a table with a column
named "name".

The problem happens only when Geoserver query answers have a column named "name".
Debugging the xml parser code, I have found in
org.geotools.xml.handlers.ComplexElementHandler that the class attribute "type"
contains the name of all table columns and some other objects.
But there are ***TWO*** instances with a name "name", when the table has such
a column. The second occurrence is related to the desired column, but the
first occurrence is something else. Maybe every type has automatically this
object with name "name", even when there is no column named "name".

The two occurrences of "name" should be treated differently.
I have fixed this bug by searching "type" backwards, from the end to the beginning, in
org.geotools.xml.handlers.xsi.ComplexTypeHandler.DefaultSequence.findChildElement.
But I don´t think it is an elegant solution - I even don´t know it is a solution
for all similar cases :-(
 My application throws an exception when I use a DataStore connected to a PostGIS
table with a column named "name". I am using Geoserver.
There is a bug that make it impossible to use a table with a column
named "name".

The problem happens only when Geoserver query answers have a column named "name".
Debugging the xml parser code, I have found in
org.geotools.xml.handlers.ComplexElementHandler that the class attribute "type"
contains the name of all table columns and some other objects.
But there are ***TWO*** instances with a name "name", when the table has such
a column. The second occurrence is related to the desired column, but the
first occurrence is something else. Maybe every type has automatically this
object with name "name", even when there is no column named "name".

The two occurrences of "name" should be treated differently.
I have fixed this bug by searching "type" backwards, from the end to the beginning, in
org.geotools.xml.handlers.xsi.ComplexTypeHandler.DefaultSequence.findChildElement.
But I don´t think it is an elegant solution - I even don´t know it is a solution
for all similar cases :-(
Jody Garnett made changes -
Fix Version/s 2.0.RC0 [ 10855 ]
Hide
Permalink
Michal Maniecki added a comment -
I was wondering if there is going to be a fix to this bug. The problem is more serious than just the "name" column.

There are 2 errors in the validation xml code, in org.geotools.xml.handlers.ComplexElementHandler.valid(Element, int)

- Schemas are case sensitive, and here elements are compared with equalsIgnoreCase( ). For GeoTools <gml:name> is the same as <gml:NAME> and that is not correct.

- Namespaces are not checked. One of the "name" elements is from a gml schema <gml:name>, the other one comes from my table <my_namespace:name>. For GeoTools they are the same.
Show
Michal Maniecki added a comment - I was wondering if there is going to be a fix to this bug. The problem is more serious than just the "name" column. There are 2 errors in the validation xml code, in org.geotools.xml.handlers.ComplexElementHandler.valid(Element, int) - Schemas are case sensitive, and here elements are compared with equalsIgnoreCase( ). For GeoTools <gml:name> is the same as <gml:NAME> and that is not correct. - Namespaces are not checked. One of the "name" elements is from a gml schema <gml:name>, the other one comes from my table <my_namespace:name>. For GeoTools they are the same.
Jody Garnett made changes -
Fix Version/s 2.7-M0 [ 15891 ]
Jody Garnett made changes -
Fix Version/s 2.7-M1 [ 16521 ]
Fix Version/s 2.7-M0 [ 15891 ]
Jody Garnett made changes -
Fix Version/s 2.7-RC1 [ 16571 ]
Fix Version/s 2.7-M1 [ 16521 ]
Jody Garnett made changes -
Fix Version/s 2.7-M3 [ 16572 ]
Fix Version/s 2.7-M2 [ 16571 ]
Justin Deoliveira made changes -
Fix Version/s 2.7-M4 [ 16726 ]
Fix Version/s 2.7-M3 [ 16572 ]
Andrea Aime made changes -
Fix Version/s 2.7-beta1 [ 16974 ]
Fix Version/s 2.7-M4 [ 16726 ]
Justin Deoliveira made changes -
Fix Version/s 2.7-RC1 [ 17076 ]
Fix Version/s 2.7-beta1 [ 16974 ]
Justin Deoliveira made changes -
Fix Version/s 2.7.0 [ 17109 ]
Fix Version/s 2.7-RC1 [ 17076 ]
Justin Deoliveira made changes -
Fix Version/s 2.7.1 [ 17255 ]
Fix Version/s 2.7.0 [ 17109 ]
Justin Deoliveira made changes -
Fix Version/s 2.7.2 [ 17359 ]
Fix Version/s 2.7.1 [ 17255 ]
Jody Garnett made changes -
Fix Version/s 2.7.3 [ 17442 ]
Fix Version/s 2.7.2 [ 17359 ]
Andrea Aime made changes -
Fix Version/s 2.7.4 [ 17863 ]
Fix Version/s 2.7.3 [ 17442 ]
Justin Deoliveira made changes -
Fix Version/s 2.7.5 [ 18236 ]
Fix Version/s 2.7.4 [ 17863 ]
Justin Deoliveira made changes -
Fix Version/s 2.7.6 [ 18554 ]
Fix Version/s 2.7.5 [ 18236 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Vladimir Oliveira Di Iorio
Vote (1)
Watch (0)

Dates

  • Created:
    Updated: