GeoTools

Add explicit delimiter to Transform process definitions

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: process
  • Labels:
    None
  • Testcase included:
    yes

Description

Using linebreaks to delimit definitions in the input to the Transform process doesn't work in WPS XML Execute requests.

Added ability to use semicolons as delimiters (keeping ability to use linefeeds as well)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment -
Hmm... this one is not really following the WPS way of doing things. The parameter should be a List<Definition> and there should be a DefinitionPPIO declared in GeoServer.
If it's really too much time to follow the "high path" I'm ok with this approach too, although this thing should really be swept under a carpet ...
Show
Andrea Aime added a comment - Hmm... this one is not really following the WPS way of doing things. The parameter should be a List<Definition> and there should be a DefinitionPPIO declared in GeoServer. If it's really too much time to follow the "high path" I'm ok with this approach too, although this thing should really be swept under a carpet ...
Hide
Permalink
Andrea Aime added a comment -
Btw, when I talk about the WPS way of doing thing I mostly refer to the idea of cramming multiple inputs into a single string (and yes, it's not the only process guilty of doing that unfortunately), whilst the WPS way to handle multiple inputs is to repeat the input.
About the PPIO, the way the API is conceived is that the processes should not be bothered with serialization/deserialization concerns, and work off plain java objects itself, while the PPIO responsibility is to handle the serialization/deserialization in one or more formats
Show
Andrea Aime added a comment - Btw, when I talk about the WPS way of doing thing I mostly refer to the idea of cramming multiple inputs into a single string (and yes, it's not the only process guilty of doing that unfortunately), whilst the WPS way to handle multiple inputs is to repeat the input. About the PPIO, the way the API is conceived is that the processes should not be bothered with serialization/deserialization concerns, and work off plain java objects itself, while the PPIO responsibility is to handle the serialization/deserialization in one or more formats
Hide
Permalink
Martin Davis added a comment -
It's not so much that it's too much trouble to follow the high road - in fact, that would be easier. I was just following the existing style of the process. I have no idea whether this process is being used and whether a change to a List input would be a breaking change.

The reason for adding the delimiter in the first place was to make this process usable from the GeoServer Request Builder UI. Changing to a List input wouldn't solve this, because the Request Builder can't create List inputs.

Since this is a completely backward compatible change which simple enhances the current implementation, I don't think it should be held up by a desire to change the interface to the implementation.
Show
Martin Davis added a comment - It's not so much that it's too much trouble to follow the high road - in fact, that would be easier. I was just following the existing style of the process. I have no idea whether this process is being used and whether a change to a List input would be a breaking change. The reason for adding the delimiter in the first place was to make this process usable from the GeoServer Request Builder UI. Changing to a List input wouldn't solve this, because the Request Builder can't create List inputs. Since this is a completely backward compatible change which simple enhances the current implementation, I don't think it should be held up by a desire to change the interface to the implementation.
Hide
Permalink
Andrea Aime added a comment -
The process was added by Jody and afaik nobody ever used it because, as you noticed, it's not usable in its current state.
The "demo builder" is just a demo, it's not meant to be something you use in production, it's just to get someone that does not have a WPS client started, designing a process structure so that they can be used there is simply wrong, a process structure needs to follow proper WPS practices.

The code for the demo builder is ugly but available, it's also possible to fix it to allow for multiple inputs (not easy though, it's something that would require a good day of work I fear).

My opinion is not changed: keeping the process as is it's ugly, but I can live with it and the patch you made makes it at least usable
Show
Andrea Aime added a comment - The process was added by Jody and afaik nobody ever used it because, as you noticed, it's not usable in its current state. The "demo builder" is just a demo, it's not meant to be something you use in production, it's just to get someone that does not have a WPS client started, designing a process structure so that they can be used there is simply wrong, a process structure needs to follow proper WPS practices. The code for the demo builder is ugly but available, it's also possible to fix it to allow for multiple inputs (not easy though, it's something that would require a good day of work I fear). My opinion is not changed: keeping the process as is it's ugly, but I can live with it and the patch you made makes it at least usable

People

  • Assignee:
    Unassigned
    Reporter:
    Martin Davis
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: