GeoTools

Remove getViewTypes() call from GridCoverage2D.toString()

Details

  • Type: Task Task
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.7.5, 8.0-RC1
  • Fix Version/s: 2.7.6, 8.0-RC2
  • Component/s: coverage
  • Labels:
    None

Description

Running some tests on GeoServer against a bigTiff datasets (60GB tif), I have encountered some rendering issues against very zoomed in requests when verbose logging is active.

Long story short, I have found that the GridCoverage2D.toString() method calls getViewTypes() which may result into a ViewsManager creating all the types of views for that coverage which may trigger several computation, image processing or what else.

I'm wondering whether this is really needed.

org.geotools.coverage.grid.ViewsManager.photographic(ViewsManager.java:292)
at org.geotools.coverage.grid.ViewsManager.get(ViewsManager.java:202)
at org.geotools.coverage.grid.GridCoverage2D.view(GridCoverage2D.java:865)
at org.geotools.coverage.grid.GridCoverage2D.getViewTypes(GridCoverage2D.java:941)
at org.geotools.coverage.grid.GridCoverage2D.toString(GridCoverage2D.java:1076)
I think we can remove the "as view" part from the toString method.

Activity

Hide
Permalink
Daniele Romagnoli added a comment -
removed the getViewTypes call from the GridCoverage2D toString()
Show
Daniele Romagnoli added a comment - removed the getViewTypes call from the GridCoverage2D toString()

People

  • Assignee:
    Daniele Romagnoli
    Reporter:
    Daniele Romagnoli
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: