GeoTools

support arithmetic filters without intermediate conversions

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 8.0-RC1
  • Fix Version/s: 8.0-RC2
  • Component/s: jdbc
  • Labels:
    None

Description

This case comes up with geoserver wfs cite tests. The tests issue a filter like:

intProperty = decimalProperty + decimalLiteral

The filter is encoded with a cast inline that cases the decimal property to an integer, throwing off the comparison.

  1. Text File
    GEOT-4166.patch
    04/Jun/12 9:55 PM
    8 kB
    Justin Deoliveira
  2. Text File
    GEOT-4166-aa.patch
    09/Jun/12 8:44 AM
    11 kB
    Andrea Aime

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. GEOT-4046 SQLException: Invalid column type in OracleFeatureSourceTest

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Justin Deoliveira added a comment -
Here is a patch for this one. Basically it checks for a binary expression and avoids the inline cast, doing the cast after the entire expression is encoded.

Tested on h2 and postgis thus far. Don;t have my oracle and sql server vms to test against at the moment.
Show
Justin Deoliveira added a comment - Here is a patch for this one. Basically it checks for a binary expression and avoids the inline cast, doing the cast after the entire expression is encoded. Tested on h2 and postgis thus far. Don;t have my oracle and sql server vms to test against at the moment.
Hide
Permalink
Andrea Aime added a comment -
Had to make some changes to make it work with Oracle, basically make sure the "lower" function is type safe (and sneaked in a unrelated fix to a Oracle test case to have a full pass).

Tested on postgis, h2, oracle, sql server and even mysql,
works fine on all it seems. Mysql has actually 7 failures and 2 errors, but they don't seem related to this patch (afaik they have been there for a while)
Show
Andrea Aime added a comment - Had to make some changes to make it work with Oracle, basically make sure the "lower" function is type safe (and sneaked in a unrelated fix to a Oracle test case to have a full pass). Tested on postgis, h2, oracle, sql server and even mysql, works fine on all it seems. Mysql has actually 7 failures and 2 errors, but they don't seem related to this patch (afaik they have been there for a while)
Hide
Permalink
Justin Deoliveira added a comment -
Thanks for the review and completing the patch Andrea!
Show
Justin Deoliveira added a comment - Thanks for the review and completing the patch Andrea!

People

  • Assignee:
    Justin Deoliveira
    Reporter:
    Justin Deoliveira
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: