GeoTools

Oracle plugin does not handle read/write of 3D Polygons correctly

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 8.0-RC1
  • Component/s: jdbc-oracle plugin
  • Labels:
    None

Description

The handling of CoordinateSequences in GeometryConverter does not correctly handle CoordinateSequence subtypes which have Z values. This shows up during reading and writing of 3D polygons of various kinds of topology (such as polygons with holes, or polygons with reversed ring orientation)

Patch will be submitted shortly.

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. GEOT-4163 Make dimension a first class information (like srid) in JDBC data stores

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Davis added a comment -
Patch solving this issue.

Main changes are:
- Fix LiteCoordinateSequenceFactory create method to maintain dimension information
- Fix Oracle Coordinates class to handle dimension correctly during reversing, extracting
Show
Martin Davis added a comment - Patch solving this issue. Main changes are: - Fix LiteCoordinateSequenceFactory create method to maintain dimension information - Fix Oracle Coordinates class to handle dimension correctly during reversing, extracting
Hide
Permalink
Justin Deoliveira added a comment -
Patch looks good to me... and comes with a superb ratio of core code to test code! :)
Show
Justin Deoliveira added a comment - Patch looks good to me... and comes with a superb ratio of core code to test code! :)
Hide
Permalink
Andrea Aime added a comment -
+1
Show
Andrea Aime added a comment - +1
Hide
Permalink
Martin Davis added a comment -
Will also be backported to 2.7.x

This patch also fixes GEOT-3215
Show
Martin Davis added a comment - Will also be backported to 2.7.x This patch also fixes GEOT-3215
Hide
Permalink
Andrea Aime added a comment -
Build is broken in Postgis3DTest, the test failing is testCreateSchemaAndInsertPolyTriangle, the first z value being compared in the test is 99 for z and NaN for p2.z

Failure stack trace is:

{code}

junit.framework.AssertionFailedError: Z values do not match
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at org.geotools.jdbc.JDBC3DTest.checkCreateSchemaAndInsert(JDBC3DTest.java:263)
at org.geotools.jdbc.JDBC3DTest.testCreateSchemaAndInsertPolyTriangle(JDBC3DTest.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at org.geotools.test.OnlineTestCase.run(OnlineTestCase.java:123)
at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
{code}
Show
Andrea Aime added a comment - Build is broken in Postgis3DTest, the test failing is testCreateSchemaAndInsertPolyTriangle, the first z value being compared in the test is 99 for z and NaN for p2.z Failure stack trace is: {code} junit.framework.AssertionFailedError: Z values do not match at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at org.geotools.jdbc.JDBC3DTest.checkCreateSchemaAndInsert(JDBC3DTest.java:263) at org.geotools.jdbc.JDBC3DTest.testCreateSchemaAndInsertPolyTriangle(JDBC3DTest.java:176) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at junit.framework.TestCase.runTest(TestCase.java:168) at junit.framework.TestCase.runBare(TestCase.java:134) at junit.framework.TestResult$1.protect(TestResult.java:110) at junit.framework.TestResult.runProtected(TestResult.java:128) at junit.framework.TestResult.run(TestResult.java:113) at junit.framework.TestCase.run(TestCase.java:124) at org.geotools.test.OnlineTestCase.run(OnlineTestCase.java:123) at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197) {code}
Hide
Permalink
Martin Davis added a comment -
Sigh....

I guess options are:

1) No-op the tests in PostGIS3DTest
2) Move the tests into the Oracle3DTest class

I prefer #1. The tests can be un-no-oped when the PostGIS driver gets some work.
Show
Martin Davis added a comment - Sigh.... I guess options are: 1) No-op the tests in PostGIS3DTest 2) Move the tests into the Oracle3DTest class I prefer #1. The tests can be un-no-oped when the PostGIS driver gets some work.

People

  • Assignee:
    Andrea Aime
    Reporter:
    Martin Davis
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: